src/hydrogen.cc - Issue 922393003: Don't always bail out of GenerateTypedArrayInitialize

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 922393003: Don't always bail out of GenerateTypedArrayInitialize (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index 902c43c1330e4c7af7f977c9a41e6d7a8733bc80..7541c5758824163445d20313cfc5df800cf657e8 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -9819,7 +9819,7 @@ void HOptimizedGraphBuilder::GenerateTypedArrayInitialize(

CHECK_ALIVE(VisitForValue(arguments->at(kObjectArg)));

HValue* obj = Pop();

- if (arguments->at(kArrayIdArg)->IsLiteral()) {

+ if (!arguments->at(kArrayIdArg)->IsLiteral()) {

// This should never happen in real use, but can happen when fuzzing.

// Just bail out.

Bailout(kNeedSmiLiteral);

« no previous file with comments | « no previous file | no next file » | no next file with comments »