chrome/browser/metrics/chrome_metrics_service_client.cc - Issue 922383003: Enable UMA log uploads for cellular networks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.cc

Issue 922383003: Enable UMA log uploads for cellular networks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Callback to get connection type Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/metrics/chrome_metrics_service_client.cc

diff --git a/chrome/browser/metrics/chrome_metrics_service_client.cc b/chrome/browser/metrics/chrome_metrics_service_client.cc

index 5d3094134cc2106451f365ecdd04e3c89ecf2da7..85875645a2b9ea157388173338af3bcd9b34eaf8 100644

--- a/chrome/browser/metrics/chrome_metrics_service_client.cc

+++ b/chrome/browser/metrics/chrome_metrics_service_client.cc

@@ -272,9 +272,10 @@ void ChromeMetricsServiceClient::Initialize() {

scoped_ptr<metrics::MetricsProvider>(

new ExtensionsMetricsProvider(metrics_state_manager_)));

#endif

- metrics_service_->RegisterMetricsProvider(

- scoped_ptr<metrics::MetricsProvider>(new metrics::NetworkMetricsProvider(

- content::BrowserThread::GetBlockingPool())));

+ metrics::NetworkMetricsProvider* network_metrics_provider =

+ new metrics::NetworkMetricsProvider(

+ content::BrowserThread::GetBlockingPool());

+ metrics_service_->SetNetworkMetricsProvider(network_metrics_provider);

metrics_service_->RegisterMetricsProvider(

scoped_ptr<metrics::MetricsProvider>(new OmniboxMetricsProvider));

metrics_service_->RegisterMetricsProvider(