Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1102)

Unified Diff: components/metrics/metrics_reporting_scheduler.cc

Issue 922383003: Enable UMA log uploads for cellular networks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Callback to set connection type in the scheduler Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/metrics_reporting_scheduler.cc
diff --git a/components/metrics/metrics_reporting_scheduler.cc b/components/metrics/metrics_reporting_scheduler.cc
index 53c0cc553f26bac20f89bc18339caadd4d01ef60..c4d43a9044d9cb22ca09339d0e61ac9c1edcdc31 100644
--- a/components/metrics/metrics_reporting_scheduler.cc
+++ b/components/metrics/metrics_reporting_scheduler.cc
@@ -38,6 +38,7 @@ const int kUnsentLogsIntervalSeconds = 15;
// Standard interval between log uploads, in seconds.
#if defined(OS_ANDROID) || defined(OS_IOS)
const int kStandardUploadIntervalSeconds = 5 * 60; // Five minutes.
+const int kStandardUploadIntervalCellularSeconds = 15 * 60; // Fifteen minutes.
#else
const int kStandardUploadIntervalSeconds = 30 * 60; // Thirty minutes.
#endif
@@ -86,13 +87,16 @@ base::TimeDelta GetUploadIntervalFromExperiment() {
} // anonymous namespace
MetricsReportingScheduler::MetricsReportingScheduler(
- const base::Closure& upload_callback)
+ const base::Closure& upload_callback,
+ const base::Closure& update_connection_type_func)
: upload_callback_(upload_callback),
upload_interval_(TimeDelta::FromSeconds(kInitialUploadIntervalSeconds)),
running_(false),
callback_pending_(false),
init_task_complete_(false),
- waiting_for_init_task_complete_(false) {
+ waiting_for_init_task_complete_(false),
+ update_connection_type_func_(update_connection_type_func),
+ is_cellular_connection_(true) {
}
MetricsReportingScheduler::~MetricsReportingScheduler() {}
@@ -194,10 +198,21 @@ void MetricsReportingScheduler::BackOffUploadInterval() {
base::TimeDelta MetricsReportingScheduler::GetStandardUploadInterval() {
#if defined(OS_ANDROID)
- return GetUploadIntervalFromExperiment();
-#else
- return TimeDelta::FromSeconds(kStandardUploadIntervalSeconds);
+ update_connection_type_func_.Run();
+ if (IsCellularEnabledByExperiment() && is_cellular_connection_)
+ return TimeDelta::FromSeconds(kStandardUploadIntervalCellularSeconds);
#endif
+ return TimeDelta::FromSeconds(kStandardUploadIntervalSeconds);
+}
+
+void MetricsReportingScheduler::SetConnectionType(bool is_cellular) {
+ is_cellular_connection_ = is_cellular;
+}
+
+bool MetricsReportingScheduler::IsCellularEnabledByExperiment() {
+ const std::string group_name =
+ base::FieldTrialList::FindFullName("UMA_EnableCellularLogUpload");
+ return group_name == "Enabled";
}
} // namespace metrics

Powered by Google App Engine
This is Rietveld 408576698