Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: components/metrics/metrics_reporting_scheduler.cc

Issue 922383003: Enable UMA log uploads for cellular networks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Field trials added Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/metrics_reporting_scheduler.cc
diff --git a/components/metrics/metrics_reporting_scheduler.cc b/components/metrics/metrics_reporting_scheduler.cc
index 53c0cc553f26bac20f89bc18339caadd4d01ef60..da6caf32387575200c9630bcd6373abe0ac64aad 100644
--- a/components/metrics/metrics_reporting_scheduler.cc
+++ b/components/metrics/metrics_reporting_scheduler.cc
@@ -38,6 +38,7 @@ const int kUnsentLogsIntervalSeconds = 15;
// Standard interval between log uploads, in seconds.
#if defined(OS_ANDROID) || defined(OS_IOS)
const int kStandardUploadIntervalSeconds = 5 * 60; // Five minutes.
+const int kStandardUploadIntervalCellularSeconds = 15 * 60; // Five minutes.
#else
const int kStandardUploadIntervalSeconds = 30 * 60; // Thirty minutes.
#endif
@@ -194,10 +195,35 @@ void MetricsReportingScheduler::BackOffUploadInterval() {
base::TimeDelta MetricsReportingScheduler::GetStandardUploadInterval() {
#if defined(OS_ANDROID)
- return GetUploadIntervalFromExperiment();
-#else
- return TimeDelta::FromSeconds(kStandardUploadIntervalSeconds);
+ if (IsCellularEnabledByExperiment() && IsCellularConnection())
+ return TimeDelta::FromSeconds(kStandardUploadIntervalCellularSeconds);
#endif
+ return TimeDelta::FromSeconds(kStandardUploadIntervalSeconds);
+}
+
+void MetricsReportingScheduler::SetNetworkMetricsProvider(
+ const metrics::NetworkMetricsProvider* network_metrics_provider) {
+ network_metrics_provider_= network_metrics_provider;
+}
+
+bool MetricsReportingScheduler::IsCellularConnection() {
+ SystemProfileProto::Network::ConnectionType connection_type =
+ network_metrics_provider_->GetConnectionType();
+
+ switch (connection_type) {
+ case SystemProfileProto_Network_ConnectionType_CONNECTION_2G:
+ case SystemProfileProto_Network_ConnectionType_CONNECTION_3G:
+ case SystemProfileProto_Network_ConnectionType_CONNECTION_4G:
+ return true;
+ default:
+ return false;
+ }
+}
+
+bool MetricsReportingScheduler::IsCellularEnabledByExperiment() {
+ const std::string group_name =
+ base::FieldTrialList::FindFullName("UMA_EnableCellularLogUpload");
+ return group_name == "Enabled";
}
} // namespace metrics

Powered by Google App Engine
This is Rietveld 408576698