Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: components/metrics/metrics_service.cc

Issue 922383003: Enable UMA log uploads for cellular networks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Metrics service is not dependent on net Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/metrics_service.cc
diff --git a/components/metrics/metrics_service.cc b/components/metrics/metrics_service.cc
index 18ec2e55bddae79355348dcc22bbf3e848231092..ffb42ef1dd9ad159e1e646fd5ec18277df4d970a 100644
--- a/components/metrics/metrics_service.cc
+++ b/components/metrics/metrics_service.cc
@@ -348,9 +348,11 @@ MetricsService::~MetricsService() {
void MetricsService::InitializeMetricsRecordingState() {
InitializeMetricsState();
- base::Closure callback = base::Bind(&MetricsService::StartScheduledUpload,
- self_ptr_factory_.GetWeakPtr());
- scheduler_.reset(new MetricsReportingScheduler(callback));
+ base::Closure upload_callback =
+ base::Bind(&MetricsService::StartScheduledUpload,
+ self_ptr_factory_.GetWeakPtr());
+ scheduler_.reset(
+ new MetricsReportingScheduler(upload_callback, is_cellular_callback_));
}
void MetricsService::Start() {
@@ -1263,4 +1265,9 @@ void MetricsService::RecordCurrentState(PrefService* pref) {
base::Time::Now().ToTimeT());
}
+void MetricsService::SetConnectionTypeCallback(
+ base::Callback<void(bool*)> is_cellular_callback) {
+ is_cellular_callback_ = is_cellular_callback;
Alexei Svitkine (slow) 2015/02/23 18:54:06 Can you add DCHECK() that InitializeMetricsRecordi
gayane -on leave until 09-2017 2015/02/23 20:14:08 Done.
+}
+
} // namespace metrics

Powered by Google App Engine
This is Rietveld 408576698