components/metrics/net/network_metrics_provider.h - Issue 922383003: Enable UMA log uploads for cellular networks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/net/network_metrics_provider.h

Issue 922383003: Enable UMA log uploads for cellular networks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: upload interval based on the connection type Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/metrics/net/network_metrics_provider.h

diff --git a/components/metrics/net/network_metrics_provider.h b/components/metrics/net/network_metrics_provider.h

index 412ef67e5ba1f399a2f8db86b24b8904e621586c..6454036dfefe87626efc6148dcf23b92a1a41cb5 100644

--- a/components/metrics/net/network_metrics_provider.h

+++ b/components/metrics/net/network_metrics_provider.h

@@ -27,6 +27,8 @@ class NetworkMetricsProvider

explicit NetworkMetricsProvider(base::TaskRunner* io_task_runner);

~NetworkMetricsProvider() override;

+ SystemProfileProto::Network::ConnectionType GetConnectionType() const;

private:

// MetricsProvider:

void OnDidCreateMetricsLog() override;

@@ -36,7 +38,6 @@ class NetworkMetricsProvider

void OnConnectionTypeChanged(

net::NetworkChangeNotifier::ConnectionType type) override;

- SystemProfileProto::Network::ConnectionType GetConnectionType() const;

SystemProfileProto::Network::WifiPHYLayerProtocol GetWifiPHYLayerProtocol()

const;