Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 922373004: Remove CHECK from createChildFrame (Closed)

Created:
5 years, 10 months ago by nasko
Modified:
5 years, 10 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove CHECK from createChildFrame The CHECK helped narrow down the reasons for the failure and we know now that the sync IPC is failing. It needs more investigation why it happens, but the check can be removed now. BUG=397744 Committed: https://crrev.com/000da13e51951ee9878eeb195e7f2d5cd43d2bb7 Cr-Commit-Position: refs/heads/master@{#316325}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M content/renderer/render_frame_impl.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Charlie Reis
LGTM
5 years, 10 months ago (2015-02-13 22:21:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922373004/1
5 years, 10 months ago (2015-02-13 22:21:53 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-13 23:34:07 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 23:35:18 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/000da13e51951ee9878eeb195e7f2d5cd43d2bb7
Cr-Commit-Position: refs/heads/master@{#316325}

Powered by Google App Engine
This is Rietveld 408576698