Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 922333002: Add new histograms to measure time in PreMainMessageLoop. (Closed)

Created:
5 years, 10 months ago by rkaplow
Modified:
5 years, 10 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add new histograms to measure time in PreMainMessageLoop. I've identified areas which cause long delays through tracing and debugging, and want to collect metrics to see the effect in the wild. I've also added new trace events to match the new histograms. BUG=454789 Committed: https://crrev.com/1b23b7d34f727d690cff990ef11a28513ce75ac4 Cr-Commit-Position: refs/heads/master@{#316284}

Patch Set 1 #

Total comments: 2

Patch Set 2 : change names to improve readability #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -2 lines) Patch
M chrome/browser/browser_process_impl.cc View 1 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.cc View 1 3 chunks +6 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
rkaplow
asvitkine@chromium.org: Please review changes in thestig@chromium.org: Please review changes in
5 years, 10 months ago (2015-02-13 17:52:27 UTC) #2
Alexei Svitkine (slow)
https://codereview.chromium.org/922333002/diff/1/chrome/browser/browser_process_impl.cc File chrome/browser/browser_process_impl.cc (right): https://codereview.chromium.org/922333002/diff/1/chrome/browser/browser_process_impl.cc#newcode1003 chrome/browser/browser_process_impl.cc:1003: "Startup.BrowserProcessImplPreMainMessageLoopRunTime"); Nit: To make these a bit more readable, ...
5 years, 10 months ago (2015-02-13 18:01:30 UTC) #3
Lei Zhang
lgtm with the underscores in the name.
5 years, 10 months ago (2015-02-13 18:34:48 UTC) #4
rkaplow
https://codereview.chromium.org/922333002/diff/1/chrome/browser/browser_process_impl.cc File chrome/browser/browser_process_impl.cc (right): https://codereview.chromium.org/922333002/diff/1/chrome/browser/browser_process_impl.cc#newcode1003 chrome/browser/browser_process_impl.cc:1003: "Startup.BrowserProcessImplPreMainMessageLoopRunTime"); On 2015/02/13 18:01:30, Alexei Svitkine wrote: > Nit: ...
5 years, 10 months ago (2015-02-13 18:44:24 UTC) #6
Alexei Svitkine (slow)
lgtm
5 years, 10 months ago (2015-02-13 18:59:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922333002/20001
5 years, 10 months ago (2015-02-13 19:01:02 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/24958)
5 years, 10 months ago (2015-02-13 20:15:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922333002/20001
5 years, 10 months ago (2015-02-13 20:19:10 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-13 20:53:03 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 20:54:20 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1b23b7d34f727d690cff990ef11a28513ce75ac4
Cr-Commit-Position: refs/heads/master@{#316284}

Powered by Google App Engine
This is Rietveld 408576698