Issue 922293003: DM: don't leak the null canvas in NullSink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 922293003: DM: don't leak the null canvas in NullSink. (Closed)

Created:
5 years, 10 months ago by mtklein_C

Modified:
5 years, 10 months ago

Reviewers:
hal.canary

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

DM: don't leak the null canvas in NullSink. Also make NullSink a real boy: declared among the other Sinks, impl in .cpp. BUG=skia: Committed: https://skia.googlesource.com/skia/+/ad66f9b15fd44468b5f013534ee333dc68d6bed6

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -10 lines)			Patch
	M	dm/DMSrcSink.h	View		3 chunks	+10 lines, -10 lines	0 comments	Download
	M	dm/DMSrcSink.cpp	View		2 chunks	+8 lines, -0 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922293003/1

5 years, 10 months ago (2015-02-13 22:36:47 UTC) #4

commit-bot: I haz the power

Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...

5 years, 10 months ago (2015-02-13 22:36:47 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-13 23:11:16 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ad66f9b15fd44468b5f013534ee333dc68d6bed6