Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Side by Side Diff: Source/bindings/templates/interface.cpp

Issue 922233002: bindings: Makes runtime-enabled attributes on prototype chains compilable. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed review comments. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/bindings/templates/constants.cpp ('k') | Source/bindings/templates/interface_base.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 {% extends 'interface_base.cpp' %} 1 {% extends 'interface_base.cpp' %}
2 2
3 3
4 {##############################################################################} 4 {##############################################################################}
5 {% block indexed_property_getter %} 5 {% block indexed_property_getter %}
6 {% if indexed_property_getter and not indexed_property_getter.is_custom %} 6 {% if indexed_property_getter and not indexed_property_getter.is_custom %}
7 {% set getter = indexed_property_getter %} 7 {% set getter = indexed_property_getter %}
8 static void indexedPropertyGetter(uint32_t index, const v8::PropertyCallbackInfo <v8::Value>& info) 8 static void indexedPropertyGetter(uint32_t index, const v8::PropertyCallbackInfo <v8::Value>& info)
9 { 9 {
10 {{cpp_class}}* impl = {{v8_class}}::toImpl(info.Holder()); 10 {{cpp_class}}* impl = {{v8_class}}::toImpl(info.Holder());
(...skipping 721 matching lines...) Expand 10 before | Expand all | Expand 10 after
732 {% set getter_callback_for_main_world = '0' %} 732 {% set getter_callback_for_main_world = '0' %}
733 {% set setter_callback_for_main_world = '0' %} 733 {% set setter_callback_for_main_world = '0' %}
734 {% endif %} 734 {% endif %}
735 {% set property_attribute = 735 {% set property_attribute =
736 'static_cast<v8::PropertyAttribute>(%s)' % 736 'static_cast<v8::PropertyAttribute>(%s)' %
737 ' | '.join(method.property_attributes or ['v8::DontDelete']) %} 737 ' | '.join(method.property_attributes or ['v8::DontDelete']) %}
738 {% set only_exposed_to_private_script = 'V8DOMConfiguration::OnlyExposedToPrivat eScript' if method.only_exposed_to_private_script else 'V8DOMConfiguration::Expo sedToAllScripts' %} 738 {% set only_exposed_to_private_script = 'V8DOMConfiguration::OnlyExposedToPrivat eScript' if method.only_exposed_to_private_script else 'V8DOMConfiguration::Expo sedToAllScripts' %}
739 static const V8DOMConfiguration::AttributeConfiguration {{method.name}}OriginSaf eAttributeConfiguration = { 739 static const V8DOMConfiguration::AttributeConfiguration {{method.name}}OriginSaf eAttributeConfiguration = {
740 "{{method.name}}", {{getter_callback}}, {{setter_callback}}, {{getter_callba ck_for_main_world}}, {{setter_callback_for_main_world}}, &{{v8_class}}::wrapperT ypeInfo, v8::ALL_CAN_READ, {{property_attribute}}, {{only_exposed_to_private_scr ipt}}, V8DOMConfiguration::OnInstance, 740 "{{method.name}}", {{getter_callback}}, {{setter_callback}}, {{getter_callba ck_for_main_world}}, {{setter_callback_for_main_world}}, &{{v8_class}}::wrapperT ypeInfo, v8::ALL_CAN_READ, {{property_attribute}}, {{only_exposed_to_private_scr ipt}}, V8DOMConfiguration::OnInstance,
741 }; 741 };
742 V8DOMConfiguration::installAttribute({{method.function_template}}, v8::Local<v8: :ObjectTemplate>(), {{method.name}}OriginSafeAttributeConfiguration, isolate); 742 V8DOMConfiguration::installAttribute(isolate, {{method.function_template}}, v8:: Local<v8::ObjectTemplate>(), {{method.name}}OriginSafeAttributeConfiguration);
743 {%- endmacro %} 743 {%- endmacro %}
744 744
745 745
746 {##############################################################################} 746 {##############################################################################}
747 {% block get_dom_template %} 747 {% block get_dom_template %}
748 {% if not is_array_buffer_or_view %} 748 {% if not is_array_buffer_or_view %}
749 v8::Local<v8::FunctionTemplate> {{v8_class}}::domTemplate(v8::Isolate* isolate) 749 v8::Local<v8::FunctionTemplate> {{v8_class}}::domTemplate(v8::Isolate* isolate)
750 { 750 {
751 {% if has_partial_interface %} 751 {% if has_partial_interface %}
752 {% set installTemplateFunction = '%s::install%sTemplateFunction' % (v8_class , v8_class) %} 752 {% set installTemplateFunction = '%s::install%sTemplateFunction' % (v8_class , v8_class) %}
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
880 void {{v8_class}}::installConditionallyEnabledProperties(v8::Local<v8::Object> i nstanceObject, v8::Isolate* isolate) 880 void {{v8_class}}::installConditionallyEnabledProperties(v8::Local<v8::Object> i nstanceObject, v8::Isolate* isolate)
881 { 881 {
882 v8::Local<v8::Object> prototypeObject = v8::Local<v8::Object>::Cast(instance Object->GetPrototype()); 882 v8::Local<v8::Object> prototypeObject = v8::Local<v8::Object>::Cast(instance Object->GetPrototype());
883 ExecutionContext* context = toExecutionContext(prototypeObject->CreationCont ext()); 883 ExecutionContext* context = toExecutionContext(prototypeObject->CreationCont ext());
884 884
885 {% for attribute in attributes if attribute.per_context_enabled_function or attribute.exposed_test %} 885 {% for attribute in attributes if attribute.per_context_enabled_function or attribute.exposed_test %}
886 {% filter per_context_enabled(attribute.per_context_enabled_function) %} 886 {% filter per_context_enabled(attribute.per_context_enabled_function) %}
887 {% filter exposed(attribute.exposed_test) %} 887 {% filter exposed(attribute.exposed_test) %}
888 static const V8DOMConfiguration::AttributeConfiguration attributeConfigurati on =\ 888 static const V8DOMConfiguration::AttributeConfiguration attributeConfigurati on =\
889 {{attribute_configuration(attribute)}}; 889 {{attribute_configuration(attribute)}};
890 V8DOMConfiguration::installAttribute(instanceObject, prototypeObject, attrib uteConfiguration, isolate); 890 V8DOMConfiguration::installAttribute(isolate, instanceObject, prototypeObjec t, attributeConfiguration);
891 {% endfilter %} 891 {% endfilter %}
892 {% endfilter %} 892 {% endfilter %}
893 {% endfor %} 893 {% endfor %}
894 } 894 }
895 895
896 {% endif %} 896 {% endif %}
897 {% endblock %} 897 {% endblock %}
898 898
899 899
900 {##############################################################################} 900 {##############################################################################}
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
980 } 980 }
981 981
982 {% for method in methods if method.overloads and method.overloads.has_partial_ov erloads %} 982 {% for method in methods if method.overloads and method.overloads.has_partial_ov erloads %}
983 void {{v8_class}}::register{{method.name | blink_capitalize}}MethodForPartialInt erface(void (*method)(const v8::FunctionCallbackInfo<v8::Value>&)) 983 void {{v8_class}}::register{{method.name | blink_capitalize}}MethodForPartialInt erface(void (*method)(const v8::FunctionCallbackInfo<v8::Value>&))
984 { 984 {
985 {{cpp_class}}V8Internal::{{method.name}}MethodForPartialInterface = method; 985 {{cpp_class}}V8Internal::{{method.name}}MethodForPartialInterface = method;
986 } 986 }
987 {% endfor %} 987 {% endfor %}
988 {% endif %} 988 {% endif %}
989 {% endblock %} 989 {% endblock %}
OLDNEW
« no previous file with comments | « Source/bindings/templates/constants.cpp ('k') | Source/bindings/templates/interface_base.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698