bindings: Makes runtime-enabled attributes on prototype chains compilable.

Source/bindings/core/v8/V8DOMConfiguration.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 159 matching lines @@
         DOMWrapperWorld& world = DOMWrapperWorld::current(isolate);
         if (callback.exposeConfiguration == OnlyExposedToPrivateScript && !world.isPrivateScriptIsolatedWorld())
             return;
 
         v8::Local<v8::FunctionTemplate> functionTemplate = functionTemplateForCallback(isolate, signature, callback.callbackForWorld(world), callback.length);
         setMethod(objectOrTemplate, callback.methodName(isolate), functionTemplate, attribute);
     }
 
     static void installAccessors(v8::Isolate*, v8::Handle<v8::ObjectTemplate>, v8::Handle<v8::Signature>, const AccessorConfiguration*, size_t accessorCount);
 
+    template<class ObjectOrTemplate>
+    static inline void installAccessor(v8::Handle<ObjectOrTemplate> instanceTemplate, v8::Handle<ObjectOrTemplate> prototype, v8::Handle<v8::Signature> signature, const AccessorConfiguration& accessor, v8::Isolate* isolate)

[haraken, 2015/02/13 15:08:24]

We might not want to duplicate the code between installAccessor and
installAccessors. Can we update installAccessors to call installAccessor and
thus share the code?

[Yuki, 2015/02/16 10:51:51]

Refactored the code a bit.
Since it seemed that getting DOMWrapperWorld is not so cheap, I made a change to
keep it during for-loops.

Also installConstant seems misleading compared to installMethod, etc.  Thus I
renamed it to installConstantWithGetter.

+    {
+        DOMWrapperWorld& world = DOMWrapperWorld::current(isolate);
+        if (accessor.exposeConfiguration == OnlyExposedToPrivateScript && !world.isPrivateScriptIsolatedWorld())
+            return;
+
+        v8::FunctionCallback getterCallback = accessor.getter;
+        v8::FunctionCallback setterCallback = accessor.setter;
+        if (world.isMainWorld()) {
+            if (accessor.getterForMainWorld)
+                getterCallback = accessor.getterForMainWorld;
+            if (accessor.setterForMainWorld)
+                setterCallback = accessor.setterForMainWorld;
+        }
+        v8::Local<v8::FunctionTemplate> getter;
+        if (getterCallback) {
+            getter = v8::FunctionTemplate::New(isolate, getterCallback, v8::External::New(isolate, const_cast<WrapperTypeInfo*>(accessor.data)), signature, 0);
+            getter->RemovePrototype();
+        }
+        v8::Local<v8::FunctionTemplate> setter;
+        if (setterCallback) {
+            setter = v8::FunctionTemplate::New(isolate, setterCallback, v8::External::New(isolate, const_cast<WrapperTypeInfo*>(accessor.data)), signature, 1);
+            setter->RemovePrototype();
+        }
+        prototype->SetAccessorProperty(v8AtomicString(isolate, accessor.name), getter, setter, accessor.attribute, accessor.settings);
+    }
+
     static v8::Local<v8::Signature> installDOMClassTemplate(v8::Isolate*, v8::Local<v8::FunctionTemplate>, const char* interfaceName, v8::Handle<v8::FunctionTemplate> parentClass, size_t fieldCount,
         const AttributeConfiguration*, size_t attributeCount,
         const AccessorConfiguration*, size_t accessorCount,
         const MethodConfiguration*, size_t callbackCount);
 
     static v8::Handle<v8::FunctionTemplate> domClassTemplate(v8::Isolate*, WrapperTypeInfo*, void (*)(v8::Local<v8::FunctionTemplate>, v8::Isolate*));
 
 private:
     static void setMethod(v8::Handle<v8::Object> target, v8::Handle<v8::Name> name, v8::Handle<v8::FunctionTemplate> functionTemplate, v8::PropertyAttribute attribute)
     {
         target->Set(name, functionTemplate->GetFunction());
     }
     static void setMethod(v8::Handle<v8::FunctionTemplate> target, v8::Handle<v8::Name> name, v8::Handle<v8::FunctionTemplate> functionTemplate, v8::PropertyAttribute attribute)
     {
         target->Set(name, functionTemplate, attribute);
     }
     static void setMethod(v8::Handle<v8::ObjectTemplate> target, v8::Handle<v8::Name> name, v8::Handle<v8::FunctionTemplate> functionTemplate, v8::PropertyAttribute attribute)
     {
         target->Set(name, functionTemplate, attribute);
     }
 
     static v8::Handle<v8::FunctionTemplate> functionTemplateForCallback(v8::Isolate*, v8::Handle<v8::Signature>, v8::FunctionCallback, int length);
 };
 
 } // namespace blink
 
 #endif // V8DOMConfiguration_h