Chromium Code Reviews| Index: tests/isolate/compile_time_error_test.dart |
| diff --git a/tests/isolate/isolate3_negative_test.dart b/tests/isolate/compile_time_error_test.dart |
| similarity index 50% |
| rename from tests/isolate/isolate3_negative_test.dart |
| rename to tests/isolate/compile_time_error_test.dart |
| index ed46f2785ef921ee4c4258785a54b78e28d44d66..4bb70c7d42b95b3d5861290a6b6ccfacef77d937 100644 |
| --- a/tests/isolate/isolate3_negative_test.dart |
| +++ b/tests/isolate/compile_time_error_test.dart |
| @@ -7,28 +7,29 @@ |
| library Isolate3NegativeTest; |
| import 'dart:isolate'; |
| -import '../../pkg/unittest/lib/unittest.dart'; |
| +import 'dart:async'; |
| +import "package:async_helper/async_helper.dart"; |
| class TestClass { |
| - TestClass.named(num this.fld1) : fld2=fld1 { |
| - TestClass.i = 0; // Should cause a compilation error. |
| - } |
| + TestClass.named(num this.fld1) |
| + // Should cause a compilation error (for the spawned isolate). It is a |
| + // runtime error for the test. |
| + : fld2 = fld1 /// 01: compile-time error |
|
kustermann
2013/11/28 09:19:47
If this results in a compile-time error in the iso
floitsch
2013/11/28 14:35:26
As discussed in person: we will have to decide wha
|
| + ; |
| num fld1; |
| num fld2; |
| } |
| void entry(SendPort replyTo) { |
| var tmp = new TestClass.named(10); |
| - replyTo.send(tmp); |
| + replyTo.send("done"); |
| } |
| main() { |
| - test("child isolate compilation errors propagate correctly. ", () { |
| - void msg_callback(var message) { |
| - // This test is a negative test and should not complete successfully. |
| - } |
| - ReceivePort response = new ReceivePort(); |
| - Isolate.spawn(entry, response.sendPort); |
| - response.first.then(expectAsync1(msg_callback)); |
| + asyncStart(); |
| + ReceivePort response = new ReceivePort(); |
| + Isolate.spawn(entry, response.sendPort); |
| + response.first.then((_) { |
| + asyncEnd(); |
| }); |
| } |