Issue 922213004: DevTools: Ignore mimetype mismatch for Image, Script, StyleSheet

Issue 922213004: DevTools: Ignore mimetype mismatch for Image, Script, StyleSheet (Closed)

Created:
5 years, 10 months ago by paulirish

Modified:
5 years, 8 months ago

Reviewers:
eustas, pfeldman

CC:
aandrey+blink_chromium.org, apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, eustas+blink_chromium.org, kozyatinskiy+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: Ignore mimetype mismatch for Image, Script, StyleSheet BUG=460669 Review superceeded here: https://codereview.chromium.org/1030473002/

Patch Set 1 #

Total comments: 1

Patch Set 2 : invert conditional. warn only for document, stylesheet, texttracks. #

Total comments: 5

Patch Set 3 : so noob. #

Patch Set 4 : Remove unncessary entries from WebInspector.NetworkManager._MIMETypes #

Total comments: 2

Patch Set 5 : rebase-update #

Patch Set 6 : updating layouttests #

Patch Set 7 : rebase-update was drunk #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+86 lines, -172 lines)			Patch
M	LayoutTests/http/tests/inspector/network/resources/script-as-text.php	View	1 2 3 4 5	1 chunk	+3 lines, -0 lines	0 comments	Download
D	LayoutTests/http/tests/inspector/network/resources/script-as-text-with-a-very-very-very-very-very-very-very-very-very-very-very-very-very-very-long-url.php	View	1 2 3 4 5	1 chunk	+0 lines, -8 lines	0 comments	Download
A	LayoutTests/http/tests/inspector/network/resources/script-with-a-very-very-very-very-very-very-very-very-very-very-very-very-very-very-long-url.php	View	1 2 3 4 5	1 chunk	+5 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/inspector/network/resources/stylesheet-as-text.php	View	1 2 3 4 5	1 chunk	+7 lines, -0 lines	0 comments	Download
M	LayoutTests/http/tests/inspector/network/script-as-text-loading.html	View	1 2 3 4 5	1 chunk	+1 line, -2 lines	0 comments	Download
D	LayoutTests/http/tests/inspector/network/script-as-text-loading-data-url.html	View	1 2 3 4 5	1 chunk	+0 lines, -30 lines	0 comments	Download
D	LayoutTests/http/tests/inspector/network/script-as-text-loading-data-url-expected.txt	View	1 2 3 4 5	1 chunk	+0 lines, -5 lines	0 comments	Download
M	LayoutTests/http/tests/inspector/network/script-as-text-loading-expected.txt	View	1 2 3 4 5	1 chunk	+3 lines, -3 lines	0 comments	Download
D	LayoutTests/http/tests/inspector/network/script-as-text-loading-long-url.html	View	1 2 3 4 5	1 chunk	+0 lines, -30 lines	0 comments	Download
D	LayoutTests/http/tests/inspector/network/script-as-text-loading-long-url-expected.txt	View	1 2 3 4 5	1 chunk	+0 lines, -5 lines	0 comments	Download
D	LayoutTests/http/tests/inspector/network/script-as-text-loading-with-caret.html	View	1 2 3 4 5	1 chunk	+0 lines, -31 lines	0 comments	Download
D	LayoutTests/http/tests/inspector/network/script-as-text-loading-with-caret-expected.txt	View	1 2 3 4 5	1 chunk	+0 lines, -5 lines	0 comments	Download
A	LayoutTests/http/tests/inspector/network/script-data-url.html	View	1 2 3 4 5	1 chunk	+30 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/inspector/network/script-data-url-expected.txt	View	1 2 3 4 5	1 chunk	+6 lines, -0 lines	0 comments	Download
A +	LayoutTests/http/tests/inspector/network/script-long-url.html	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
A	LayoutTests/http/tests/inspector/network/script-long-url-expected.txt	View	1 2 3 4 5	1 chunk	+6 lines, -0 lines	0 comments	Download
A +	LayoutTests/http/tests/inspector/network/script-with-caret.html	View	1 2 3 4 5	2 chunks	+2 lines, -3 lines	0 comments	Download
A	LayoutTests/http/tests/inspector/network/script-with-caret-expected.txt	View	1 2 3 4 5	1 chunk	+6 lines, -0 lines	0 comments	Download
A +	LayoutTests/http/tests/inspector/network/stylesheet-as-text-loading.html	View	1 2 3 4 5	2 chunks	+7 lines, -9 lines	0 comments	Download
A	LayoutTests/http/tests/inspector/network/stylesheet-as-text-loading-expected.txt	View	1 2 3 4 5	1 chunk	+4 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/sdk/NetworkManager.js	View	1 2 3 4 5	2 chunks	+5 lines, -40 lines	0 comments	Download

Messages

Total messages: 35 (15 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

eustas

lgtm https://codereview.chromium.org/922213004/diff/1/Source/devtools/front_end/sdk/NetworkManager.js File Source/devtools/front_end/sdk/NetworkManager.js (right): https://codereview.chromium.org/922213004/diff/1/Source/devtools/front_end/sdk/NetworkManager.js#newcode269 Source/devtools/front_end/sdk/NetworkManager.js:269: || resourceType === WebInspector.resourceTypes.Image If we exclude all ...

5 years, 10 months ago (2015-02-24 05:59:22 UTC) #3

pfeldman

withdrawing n-o-t lgtm, agreeing with eustas's suggestion to invert.

5 years, 10 months ago (2015-02-24 19:18:22 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922213004/20001

5 years, 10 months ago (2015-02-24 19:53:26 UTC) #8

pfeldman

https://codereview.chromium.org/922213004/diff/20001/Source/devtools/front_end/sdk/NetworkManager.js File Source/devtools/front_end/sdk/NetworkManager.js (right): https://codereview.chromium.org/922213004/diff/20001/Source/devtools/front_end/sdk/NetworkManager.js#newcode270 Source/devtools/front_end/sdk/NetworkManager.js:270: || resourceType !== WebInspector.resourceTypes.Document I wonder if you want ...

5 years, 10 months ago (2015-02-24 20:02:31 UTC) #11

paulirish

5 years, 10 months ago (2015-02-24 20:03:59 UTC) #12

pfeldman

https://codereview.chromium.org/922213004/diff/20001/Source/devtools/front_end/sdk/NetworkManager.js File Source/devtools/front_end/sdk/NetworkManager.js (right): https://codereview.chromium.org/922213004/diff/20001/Source/devtools/front_end/sdk/NetworkManager.js#newcode65 Source/devtools/front_end/sdk/NetworkManager.js:65: "image/jpg": {"image": true}, While you are here, you might ...

5 years, 10 months ago (2015-02-24 20:07:18 UTC) #13

paulirish

Thanks for the review https://codereview.chromium.org/922213004/diff/20001/Source/devtools/front_end/sdk/NetworkManager.js File Source/devtools/front_end/sdk/NetworkManager.js (right): https://codereview.chromium.org/922213004/diff/20001/Source/devtools/front_end/sdk/NetworkManager.js#newcode65 Source/devtools/front_end/sdk/NetworkManager.js:65: "image/jpg": {"image": true}, On 2015/02/24 ...

5 years, 10 months ago (2015-02-24 20:11:33 UTC) #14

pfeldman

https://codereview.chromium.org/922213004/diff/60001/Source/devtools/front_end/sdk/NetworkManager.js File Source/devtools/front_end/sdk/NetworkManager.js (left): https://codereview.chromium.org/922213004/diff/60001/Source/devtools/front_end/sdk/NetworkManager.js#oldcode71 Source/devtools/front_end/sdk/NetworkManager.js:71: "image/svg+xml": {"image": true, "font": true, "document": true}, Leave this ...

5 years, 10 months ago (2015-02-24 20:27:59 UTC) #16

paulirish

https://codereview.chromium.org/922213004/diff/60001/Source/devtools/front_end/sdk/NetworkManager.js File Source/devtools/front_end/sdk/NetworkManager.js (right): https://codereview.chromium.org/922213004/diff/60001/Source/devtools/front_end/sdk/NetworkManager.js#newcode63 Source/devtools/front_end/sdk/NetworkManager.js:63: "image/svg+xml": {"document": true}, Good idea ^

5 years, 10 months ago (2015-02-24 20:32:00 UTC) #17

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922213004/60001

5 years, 10 months ago (2015-02-24 20:32:35 UTC) #20

commit-bot: I haz the power

Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/52208)

5 years, 10 months ago (2015-02-24 23:34:27 UTC) #22

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922213004/80001

5 years, 10 months ago (2015-02-25 06:11:44 UTC) #25

commit-bot: I haz the power

Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/48677)

5 years, 10 months ago (2015-02-25 07:57:08 UTC) #27

paulirish

I'm not sure how to address this layouttest failure: http://i.imgur.com/TzKIeou.png ideas?

5 years, 9 months ago (2015-03-07 04:40:22 UTC) #28

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922213004/120001

5 years, 9 months ago (2015-03-07 04:48:32 UTC) #31

commit-bot: I haz the power

Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/53960)

5 years, 9 months ago (2015-03-07 07:53:05 UTC) #33

paulirish

5 years, 8 months ago (2015-04-02 21:42:06 UTC) #35

Taken over here:
https://codereview.chromium.org/1030473002/

thanks!

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages