Source/core/layout/LayoutBlock.h - Issue 922173002: Don't pass semi-detached renderers to the flow thread (or anyone else).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutBlock.h

Issue 922173002: Don't pass semi-detached renderers to the flow thread (or anyone else). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Code review - make a helper method. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/multicol/dynamic/insert-block-among-text-in-anonymous-wrapper-expected.html ('k') | Source/core/layout/LayoutBlock.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/layout/LayoutBlock.h

diff --git a/Source/core/layout/LayoutBlock.h b/Source/core/layout/LayoutBlock.h

index 234498131e3dbd39f2d6f6571193f418a53609d8..bf93c6a5d746159d0e971bffe76c3b16fa679ade 100644

--- a/Source/core/layout/LayoutBlock.h

+++ b/Source/core/layout/LayoutBlock.h

@@ -332,6 +332,10 @@ private:

virtual bool isLayoutBlock() const override final { return true; }

void makeChildrenNonInline(LayoutObject* insertionPoint = 0);

+ // Promote all children and make them siblings that come right after this block.

+ void promoteAllChildrenAndInsertAfter();

virtual void removeLeftoverAnonymousBlock(LayoutBlock* child);

static void collapseAnonymousBlockChild(LayoutBlock* parent, LayoutBlock* child);