Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 922153002: Move identical code from platform specific assemblers to assembler.cc (Closed)

Created:
5 years, 10 months ago by loislo
Modified:
5 years, 10 months ago
Reviewers:
Sven Panne, alph, yurys
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move identical code from platform specific assemblers to assembler.cc BUG=none LOG=n Committed: https://crrev.com/a82d3dc8f98f985b31b83c7428c388f1d350a31c Cr-Commit-Position: refs/heads/master@{#26639}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -255 lines) Patch
M src/arm/assembler-arm.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M src/arm64/assembler-arm64.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M src/assembler.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M src/ia32/assembler-ia32.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M src/mips/assembler-mips.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M src/mips64/assembler-mips64.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M src/ppc/assembler-ppc.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M src/x64/assembler-x64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M src/x87/assembler-x87.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/x87/assembler-x87.cc View 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
loislo
5 years, 10 months ago (2015-02-13 07:23:12 UTC) #2
yurys
lgtm
5 years, 10 months ago (2015-02-13 07:33:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922153002/1
5 years, 10 months ago (2015-02-13 10:36:56 UTC) #6
Sven Panne
lgtm
5 years, 10 months ago (2015-02-13 10:36:59 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-13 10:45:33 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 10:45:49 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a82d3dc8f98f985b31b83c7428c388f1d350a31c
Cr-Commit-Position: refs/heads/master@{#26639}

Powered by Google App Engine
This is Rietveld 408576698