Issue 922133002: Fix a closure compiler error by modifying gyp and the extern

Issue 922133002: Fix a closure compiler error by modifying gyp and the extern (Closed)

Created:
5 years, 10 months ago by yoshiki

Modified:
5 years, 10 months ago

Reviewers:
hirono, Dan Beam

CC:
chromium-reviews, vitalyp+closure_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, dbeam+watch-closure_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Fix a closure compiler error by modifying gyp and the extern This is follow up CL to crrev.com/922593002 BUG=442214 TEST=compiled_resources.gyp passes TBR=hirono@chromium.org Committed: https://crrev.com/fe39916fcc7d6186f82d32b903fba01f07791c4b Cr-Commit-Position: refs/heads/master@{#316186}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	ui/file_manager/externs/gallery_background.js	View		1 chunk	+1 line, -2 lines	0 comments	Download
	M	ui/file_manager/gallery/js/compiled_resources.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 7 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922133002/1

5 years, 10 months ago (2015-02-13 07:13:28 UTC) #3

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/fe39916fcc7d6186f82d32b903fba01f07791c4b Cr-Commit-Position: refs/heads/master@{#316186}

5 years, 10 months ago (2015-02-13 07:36:46 UTC) #5

Dan Beam

5 years, 10 months ago (2015-02-14 01:40:55 UTC) #7

Message was sent while issue was closed.

this didn't fix the compile...
http://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Lin...