Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 92213002: Add support for Chrome policy type that references external data (Closed)

Created:
7 years ago by bartfab (slow)
Modified:
7 years ago
Reviewers:
Joao da Silva
CC:
grit-developer_googlegroups.com
Visibility:
Public.

Description

Add support for Chrome policy type that references external data This CL adds support for a Chrome policy type that references external data. BUG=256635 TEST=Ran Chrome's target policy_templates R=joaodasilva@chromium.org Committed: https://code.google.com/p/grit-i18n/source/detail?r=140

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -17 lines) Patch
M grit/format/policy_templates/writers/adm_writer.py View 1 chunk +4 lines, -0 lines 0 comments Download
M grit/format/policy_templates/writers/adml_writer.py View 1 chunk +3 lines, -0 lines 0 comments Download
M grit/format/policy_templates/writers/admx_writer.py View 1 chunk +3 lines, -0 lines 0 comments Download
M grit/format/policy_templates/writers/doc_writer.py View 3 chunks +20 lines, -15 lines 0 comments Download
M grit/format/policy_templates/writers/json_writer.py View 1 chunk +3 lines, -0 lines 0 comments Download
M grit/format/policy_templates/writers/plist_strings_writer.py View 1 1 chunk +4 lines, -1 line 0 comments Download
M grit/format/policy_templates/writers/plist_writer.py View 1 chunk +3 lines, -0 lines 0 comments Download
M grit/format/policy_templates/writers/reg_writer.py View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
bartfab (slow)
Hi Joao, Could you take a look?
7 years ago (2013-11-27 18:22:34 UTC) #1
Joao da Silva
lgtm
7 years ago (2013-11-27 18:31:14 UTC) #2
bartfab (slow)
Can you commit this too? /me lacks commit rights in grit.
7 years ago (2013-11-27 18:32:05 UTC) #3
Joao da Silva
7 years ago (2013-11-27 18:40:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r140 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698