Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(850)

Issue 922123002: Make sky/tests/services/event-sender.sky pass (Closed)

Created:
5 years, 10 months ago by abarth-chromium
Modified:
5 years, 10 months ago
Reviewers:
rafaelw, eseidel
CC:
mojo-reviews_chromium.org, ojan, esprehn, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make sky/tests/services/event-sender.sky pass This CL ports sky/framework/shell.sky to Dart and makes event-sender.sky. I've also removed a number of not-that-interesting tests for the JS Mojo bindings. R=eseidel@chromium.org, rafaelw@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/dd5a7b6a0bd695d6589283f9899762b50d726f47

Patch Set 1 #

Patch Set 2 : Moar simple #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -81 lines) Patch
A sky/framework/shell.dart View 1 1 chunk +23 lines, -0 lines 1 comment Download
D sky/framework/shell.sky View 1 chunk +0 lines, -11 lines 0 comments Download
M sky/tests/TestExpectations View 2 chunks +1 line, -7 lines 0 comments Download
D sky/tests/services/buffer.sky View 1 chunk +0 lines, -9 lines 0 comments Download
D sky/tests/services/buffer-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D sky/tests/services/codec.sky View 1 chunk +0 lines, -9 lines 0 comments Download
D sky/tests/services/codec-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D sky/tests/services/core.sky View 1 chunk +0 lines, -9 lines 0 comments Download
D sky/tests/services/core-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M sky/tests/services/event-sender.sky View 1 chunk +31 lines, -28 lines 0 comments Download
M sky/tests/services/event-sender-expected.txt View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
abarth-chromium
5 years, 10 months ago (2015-02-13 06:54:54 UTC) #1
eseidel
lgtm Did you mean to delete these services tests? https://codereview.chromium.org/922123002/diff/20001/sky/framework/shell.dart File sky/framework/shell.dart (right): https://codereview.chromium.org/922123002/diff/20001/sky/framework/shell.dart#newcode5 sky/framework/shell.dart:5: ...
5 years, 10 months ago (2015-02-13 18:38:18 UTC) #3
abarth-chromium
Committed patchset #2 (id:20001) manually as dd5a7b6a0bd695d6589283f9899762b50d726f47 (presubmit successful).
5 years, 10 months ago (2015-02-13 21:52:12 UTC) #4
abarth-chromium
5 years, 10 months ago (2015-02-13 21:53:19 UTC) #5
Message was sent while issue was closed.
On 2015/02/13 at 18:38:18, eseidel wrote:
> Did you mean to delete these services tests?

Yes.  I noted it in the description.  They were testing trivial properties of
the JS Mojo bindings.

>
https://codereview.chromium.org/922123002/diff/20001/sky/framework/shell.dart...
> sky/framework/shell.dart:5: import "/mojo/public/dart/application.dart";
> Does this work?  You used relative paths in the last CL I reviewed.  This
seems better if it works.

This works.  Application.dart isn't in the "gen" directory.  It's just in the
source tree.

Powered by Google App Engine
This is Rietveld 408576698