Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: sky/specs/elements.md

Issue 922113003: Specs: add TODO for renaming insertBefore; rename appendSingle() (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/specs/elements.md
diff --git a/sky/specs/elements.md b/sky/specs/elements.md
index 02558c97df261825b400a636046cd1861ba5cbd8..3e7ba623ac04f688b47b34afa81f9a295f9786b1 100644
--- a/sky/specs/elements.md
+++ b/sky/specs/elements.md
@@ -24,6 +24,8 @@ abstract class Node extends EventTarget {
// the following all throw if parentNode is null
external void insertBefore(List nodes); // O(N) in number of arguments plus all their descendants
external void insertAfter(List nodes); // O(N) in number of arguments plus all their descendants
+ // TODO(ianh): rename insertBefore() and insertAfter() since the Web has an insertBefore() that means
+ // something else. What's a good name, though?
external void replaceWith(List nodes); // O(N) in number of descendants plus arguments plus all their descendants
// nodes must be String, Text, or Element
@@ -76,7 +78,7 @@ abstract class ParentNode extends Node {
// TODO(ianh): might not be necessary if we have the parser drop unnecessary whitespace text nodes
external void append(List nodes); // O(N) in number of arguments plus all their descendants
- external void appendSingle(Node nodes); // O(N) in number of descandants
+ external void appendChild(Node child); // O(N) in number of descandants
external void prepend(List nodes); // O(N) in number of arguments plus all their descendants
external void replaceChildrenWith(List nodes); // O(N) in number of descendants plus arguments plus all their descendants
// nodes must be String, Text, or Element
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698