Clean up app_shell GN build.

Clean up app_shell GN build.

This unifies sources lists between GYP and GN
builds and gets app_shell_unittests building
on GN in most environments.

BUG=

Committed: https://crrev.com/466cf20fff0d3169c1c548f94b85c42d78ae3a2f
Cr-Commit-Position: refs/heads/master@{#316312}

[Ken Rockot(use gerrit already), 2015-02-13 21:44:13]

rockot@chromium.org changed reviewers:
+ jamescook@chromium.org

[Ken Rockot(use gerrit already), 2015-02-13 21:44:14]

James could you please take a look?

[James Cook, 2015-02-13 21:53:32]

LGTM with one question

https://codereview.chromium.org/922093002/diff/1/extensions/BUILD.gn
File extensions/BUILD.gn (right):

https://codereview.chromium.org/922093002/diff/1/extensions/BUILD.gn#newcode90
extensions/BUILD.gn:90: "//content/public/browser",
Question: Why does this have to be a public_dep?  (I'm not saying it shouldn't,
I just don't understand what motivates it.)

https://codereview.chromium.org/922093002/diff/1/extensions/shell/BUILD.gn
File extensions/shell/BUILD.gn (right):

https://codereview.chromium.org/922093002/diff/1/extensions/shell/BUILD.gn#ne...
extensions/shell/BUILD.gn:87: # TODO(GYP): Enable this when //components/nacl GN
is done.
Can you maybe file a bug for this? Or reference the tracking bug for
//components/nacl?  It's going to be confusing if the GN version of app-shell
builds but mysteriously doesn't support NaCl.

[Ken Rockot(use gerrit already), 2015-02-13 22:07:34]

New patchsets have been uploaded after l-g-t-m from jamescook@chromium.org

[Ken Rockot(use gerrit already), 2015-02-13 22:08:31]

https://codereview.chromium.org/922093002/diff/1/extensions/BUILD.gn
File extensions/BUILD.gn (right):

https://codereview.chromium.org/922093002/diff/1/extensions/BUILD.gn#newcode90
extensions/BUILD.gn:90: "//content/public/browser",
On 2015/02/13 21:53:31, James Cook wrote:
> Question: Why does this have to be a public_dep?  (I'm not saying it
shouldn't,
> I just don't understand what motivates it.)

Good question!

It's because one of the public headers of the test_support target (namely
extensions_test.h) exposes one of the headers of the content/public/browser
target. Without the dependency being public, targets which depend on
test_support may not receive sufficient build configuration to find that header.

That's effectively the only rule to determine choice between deps or
public_deps: if A depends on B and A's public interface exposes this dependency,
then B is a public dependency of A.

https://codereview.chromium.org/922093002/diff/1/extensions/shell/BUILD.gn
File extensions/shell/BUILD.gn (right):

https://codereview.chromium.org/922093002/diff/1/extensions/shell/BUILD.gn#ne...
extensions/shell/BUILD.gn:87: # TODO(GYP): Enable this when //components/nacl GN
is done.
On 2015/02/13 21:53:31, James Cook wrote:
> Can you maybe file a bug for this? Or reference the tracking bug for
> //components/nacl?  It's going to be confusing if the GN version of app-shell
> builds but mysteriously doesn't support NaCl.

Added a ref to the nacl GN bug

[Ken Rockot(use gerrit already), 2015-02-13 22:18:36]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2015-02-13 22:20:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/922093002/20001

[commit-bot: I haz the power, 2015-02-13 23:03:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-13 23:04:41]

Patchset 2 (id:??) landed as
https://crrev.com/466cf20fff0d3169c1c548f94b85c42d78ae3a2f
Cr-Commit-Position: refs/heads/master@{#316312}