Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 922083002: Add initializeFromShellProxy to application.dart (Closed)

Created:
5 years, 10 months ago by abarth-chromium
Modified:
5 years, 10 months ago
Reviewers:
zra, zra
CC:
Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, rafaelw, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add initializeFromShellProxy to application.dart This CL adds the ability to initialize the Dart Application class with a shell proxy (rather than with a MojoHandle). This change lets Sky use the Dart bindings for Mojo. This CL was reviewed on the SkyDart branch in https://codereview.chromium.org/919883002/ R=zra@google.com, zra@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/94a22312a24fb2ca262f3f9fb5b3ba377b29844b

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M mojo/public/dart/src/application.dart View 1 chunk +7 lines, -0 lines 1 comment Download
M sky/examples/dart-mojo.sky View 2 chunks +2 lines, -2 lines 2 comments Download

Messages

Total messages: 6 (1 generated)
abarth-chromium
5 years, 10 months ago (2015-02-13 05:58:49 UTC) #1
abarth-chromium
@zra: You saw this change before on the SkyDart branch, but we're ready to land ...
5 years, 10 months ago (2015-02-13 06:00:13 UTC) #2
zra
lgtm with nit https://codereview.chromium.org/922083002/diff/1/mojo/public/dart/src/application.dart File mojo/public/dart/src/application.dart (right): https://codereview.chromium.org/922083002/diff/1/mojo/public/dart/src/application.dart#newcode92 mojo/public/dart/src/application.dart:92: // mojo services. Do not use ...
5 years, 10 months ago (2015-02-13 07:14:24 UTC) #4
abarth-chromium
Thanks! https://codereview.chromium.org/922083002/diff/1/sky/examples/dart-mojo.sky File sky/examples/dart-mojo.sky (right): https://codereview.chromium.org/922083002/diff/1/sky/examples/dart-mojo.sky#newcode77 sky/examples/dart-mojo.sky:77: var shellProxy = new shell_mojom.ShellProxy.fromHandle(new MojoHandle(internals.passShellProxyHandle())); On 2015/02/13 ...
5 years, 10 months ago (2015-02-13 07:16:50 UTC) #5
abarth-chromium
5 years, 10 months ago (2015-02-13 07:52:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
94a22312a24fb2ca262f3f9fb5b3ba377b29844b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698