Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(949)

Issue 922073002: Explicitly reset the speech state when closing the app launcher. (Closed)

Created:
5 years, 10 months ago by Anand Mistry (off Chromium)
Modified:
5 years, 10 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Explicitly reset the speech state when closing the app launcher. If the launcher was in the middle of speech recognition when it was closed, it get's stuck in the RECOGNIZING state which prevents hotwording from working in the future. Explicitly reset the state so this doesn't happen. BUG=458277 Committed: https://crrev.com/2cafdd4b20176e66da2b8ec87e87546ab6a3e36d Cr-Commit-Position: refs/heads/master@{#316417}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/ui/app_list/start_page_service.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Anand Mistry (off Chromium)
5 years, 10 months ago (2015-02-13 05:10:30 UTC) #2
calamity
lgtm
5 years, 10 months ago (2015-02-16 00:36:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922073002/1
5 years, 10 months ago (2015-02-16 00:38:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-16 01:34:46 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-16 01:35:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2cafdd4b20176e66da2b8ec87e87546ab6a3e36d
Cr-Commit-Position: refs/heads/master@{#316417}

Powered by Google App Engine
This is Rietveld 408576698