Sort experimental app list search result groups.

Sort experimental app list search result groups.

This CL sorts the search page view's child views by their first result's
score.

BUG=440073
Committed: https://crrev.com/e163230b8106de1ae33dd74e16edfb01c51debd6
Cr-Commit-Position: refs/heads/master@{#316769}

[calamity, 2015-02-17 07:06:19]

Patchset #1 (id:1) has been deleted

[calamity, 2015-02-17 07:07:02]

calamity@chromium.org changed reviewers:
+ mgiuca@chromium.org

[calamity, 2015-02-17 07:09:02]

Patchset #2 (id:40001) has been deleted

[Matt Giuca, 2015-02-17 08:24:20]

lgtm

Very cool.

https://codereview.chromium.org/922063003/diff/60001/ui/app_list/search/mixer.cc
File ui/app_list/search/mixer.cc (right):

https://codereview.chromium.org/922063003/diff/60001/ui/app_list/search/mixer...
ui/app_list/search/mixer.cc:224: result_copy->set_relevance(sort_data.score);
Yeah good, I needed this the other day and I hacked around it instead of just
doing it.

https://codereview.chromium.org/922063003/diff/60001/ui/app_list/views/search...
File ui/app_list/views/search_result_page_view.cc (right):

https://codereview.chromium.org/922063003/diff/60001/ui/app_list/views/search...
ui/app_list/views/search_result_page_view.cc:140: return a->container_score() >
b->container_score();
LAMBDA!!!!

Half-Life 3 confirmed.

https://codereview.chromium.org/922063003/diff/60001/ui/app_list/views/search...
File ui/app_list/views/search_result_page_view_unittest.cc (right):

https://codereview.chromium.org/922063003/diff/60001/ui/app_list/views/search...
ui/app_list/views/search_result_page_view_unittest.cc:134:
tile_result->set_relevance(1.0);
Can you make this 0.4 (so the TILE comes in between the two LISTs). That way, we
test that ALL the lists come before all the tiles (the 0.3 gets bumped up above
the 0.4, despite having a lower score, because it joins the list).

[calamity, 2015-02-18 00:45:46]

New patchsets have been uploaded after l-g-t-m from mgiuca@chromium.org

[calamity, 2015-02-18 01:28:30]

https://codereview.chromium.org/922063003/diff/60001/ui/app_list/search/mixer.cc
File ui/app_list/search/mixer.cc (right):

https://codereview.chromium.org/922063003/diff/60001/ui/app_list/search/mixer...
ui/app_list/search/mixer.cc:224: result_copy->set_relevance(sort_data.score);
On 2015/02/17 08:24:20, Matt Giuca wrote:
> Yeah good, I needed this the other day and I hacked around it instead of just
> doing it.

Acknowledged.

https://codereview.chromium.org/922063003/diff/60001/ui/app_list/views/search...
File ui/app_list/views/search_result_page_view.cc (right):

https://codereview.chromium.org/922063003/diff/60001/ui/app_list/views/search...
ui/app_list/views/search_result_page_view.cc:140: return a->container_score() >
b->container_score();
On 2015/02/17 08:24:20, Matt Giuca wrote:
> LAMBDA!!!!
> 
> Half-Life 3 confirmed.

Acknowledged.

https://codereview.chromium.org/922063003/diff/60001/ui/app_list/views/search...
File ui/app_list/views/search_result_page_view_unittest.cc (right):

https://codereview.chromium.org/922063003/diff/60001/ui/app_list/views/search...
ui/app_list/views/search_result_page_view_unittest.cc:134:
tile_result->set_relevance(1.0);
On 2015/02/17 08:24:20, Matt Giuca wrote:
> Can you make this 0.4 (so the TILE comes in between the two LISTs). That way,
we
> test that ALL the lists come before all the tiles (the 0.3 gets bumped up
above
> the 0.4, despite having a lower score, because it joins the list).

Done.

[calamity, 2015-02-18 01:28:35]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2015-02-18 01:29:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/922063003/80001

[commit-bot: I haz the power, 2015-02-18 02:34:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-18 02:34:41]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[calamity, 2015-02-18 04:27:30]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2015-02-18 04:28:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/922063003/100001

[commit-bot: I haz the power, 2015-02-18 04:42:42]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2015-02-18 04:43:18]

Patchset 4 (id:??) landed as
https://crrev.com/e163230b8106de1ae33dd74e16edfb01c51debd6
Cr-Commit-Position: refs/heads/master@{#316769}