Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 922063003: Sort experimental app list search result groups. (Closed)

Created:
5 years, 10 months ago by calamity
Modified:
5 years, 10 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_search_results_not_being_there
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sort experimental app list search result groups. This CL sorts the search page view's child views by their first result's score. BUG=440073 Committed: https://crrev.com/e163230b8106de1ae33dd74e16edfb01c51debd6 Cr-Commit-Position: refs/heads/master@{#316769}

Patch Set 1 : add test #

Patch Set 2 : rebase #

Total comments: 6

Patch Set 3 : address comment #

Patch Set 4 : force test to be experimental app list #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -11 lines) Patch
M ui/app_list/search/mixer.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
M ui/app_list/search_result.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M ui/app_list/test/test_search_result.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ui/app_list/test/test_search_result.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M ui/app_list/views/search_result_container_view.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ui/app_list/views/search_result_list_view.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/app_list/views/search_result_list_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/search_result_page_view.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/app_list/views/search_result_page_view.cc View 1 1 chunk +15 lines, -0 lines 0 comments Download
M ui/app_list/views/search_result_page_view_unittest.cc View 1 2 3 4 chunks +46 lines, -2 lines 0 comments Download
M ui/app_list/views/search_result_tile_item_list_view.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
calamity
5 years, 10 months ago (2015-02-17 07:07:02 UTC) #3
Matt Giuca
lgtm Very cool. https://codereview.chromium.org/922063003/diff/60001/ui/app_list/search/mixer.cc File ui/app_list/search/mixer.cc (right): https://codereview.chromium.org/922063003/diff/60001/ui/app_list/search/mixer.cc#newcode224 ui/app_list/search/mixer.cc:224: result_copy->set_relevance(sort_data.score); Yeah good, I needed this ...
5 years, 10 months ago (2015-02-17 08:24:20 UTC) #5
calamity
https://codereview.chromium.org/922063003/diff/60001/ui/app_list/search/mixer.cc File ui/app_list/search/mixer.cc (right): https://codereview.chromium.org/922063003/diff/60001/ui/app_list/search/mixer.cc#newcode224 ui/app_list/search/mixer.cc:224: result_copy->set_relevance(sort_data.score); On 2015/02/17 08:24:20, Matt Giuca wrote: > Yeah ...
5 years, 10 months ago (2015-02-18 01:28:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922063003/80001
5 years, 10 months ago (2015-02-18 01:29:53 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/33643)
5 years, 10 months ago (2015-02-18 02:34:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922063003/100001
5 years, 10 months ago (2015-02-18 04:28:32 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:100001)
5 years, 10 months ago (2015-02-18 04:42:42 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 04:43:18 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e163230b8106de1ae33dd74e16edfb01c51debd6
Cr-Commit-Position: refs/heads/master@{#316769}

Powered by Google App Engine
This is Rietveld 408576698