Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 922043005: MIPS: Fix 'Assembler support for internal references.' (Closed)

Created:
5 years, 10 months ago by balazs.kilvady
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix 'Assembler support for internal references.' Added new INTERNAL_REFERENCE_ENCODED RelocInfo type to differentiate MIPS existing use of internal references in instructions from the new raw pointer reference needed for dd(Label*). BUG= TEST=cctest/test-assembler-mips/jump_tables1, cctest/test-assembler-mips/jump_tables2, cctest/test-assembler-mips/jump_tables3, cctest/test-run-machops/RunSwitch1 Committed: https://crrev.com/244ac6de8316259bc5878480e05348a369c08e2f Cr-Commit-Position: refs/heads/master@{#26651}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -90 lines) Patch
M src/assembler.h View 2 chunks +8 lines, -0 lines 0 comments Download
M src/mips/assembler-mips.h View 5 chunks +11 lines, -4 lines 0 comments Download
M src/mips/assembler-mips.cc View 12 chunks +92 lines, -80 lines 0 comments Download
M src/mips/assembler-mips-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips/constants-mips.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips/macro-assembler-mips.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
balazs.kilvady
5 years, 10 months ago (2015-02-13 19:29:54 UTC) #2
paul.l...
LGTM. This needs v8 team reviewer for the small changes in assembler.h
5 years, 10 months ago (2015-02-13 19:32:17 UTC) #3
Jakob Kummerow
lgtm
5 years, 10 months ago (2015-02-14 13:17:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922043005/1
5 years, 10 months ago (2015-02-15 12:28:04 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-15 12:50:46 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/244ac6de8316259bc5878480e05348a369c08e2f Cr-Commit-Position: refs/heads/master@{#26651}
5 years, 10 months ago (2015-02-15 12:50:56 UTC) #8
Michael Achenbach
5 years, 10 months ago (2015-02-16 18:48:43 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/934623003/ by machenbach@chromium.org.

The reason for reverting is: Breaks
http://build.chromium.org/p/chromium.fyi/builders/Android%20MIPS%20Builder%20....

Powered by Google App Engine
This is Rietveld 408576698