Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 922043004: C++11 Unit Test for RValue semantics. (Closed)

Created:
5 years, 10 months ago by hal.canary
Modified:
5 years, 10 months ago
Reviewers:
scroggo, mtklein
CC:
reviews_skia.org, scroggo
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

C++11 Unit Test for RValue semantics. Motivation: test that these works on all possible bots and for all possible clients (clients do run these unit tests, right?) Dear clients: if this unit test fails, let us know! BUG=skia:3427 Committed: https://skia.googlesource.com/skia/+/3a6672ae0c95f24f873dca21424e060df9f9c3e5

Patch Set 1 : 2015-02-13 (Friday) 16:15:17 EST #

Patch Set 2 : 2015-02-13 (Friday) 17:54:58 EST #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M gyp/tests.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
A tests/CPlusPlusEleven.cpp View 1 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 33 (13 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922043004/1
5 years, 10 months ago (2015-02-13 19:17:44 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-13 19:17:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922043004/20001
5 years, 10 months ago (2015-02-13 19:29:55 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-13 19:29:55 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot/builds/2050)
5 years, 10 months ago (2015-02-13 19:32:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922043004/40001
5 years, 10 months ago (2015-02-13 21:06:46 UTC) #12
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-13 21:06:47 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922043004/60001
5 years, 10 months ago (2015-02-13 21:17:46 UTC) #15
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-13 21:17:47 UTC) #16
hal.canary
ptal
5 years, 10 months ago (2015-02-13 21:23:53 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922043004/100001
5 years, 10 months ago (2015-02-13 22:56:07 UTC) #20
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-13 22:56:08 UTC) #21
mtklein
lgtm
5 years, 10 months ago (2015-02-13 22:57:35 UTC) #22
commit-bot: I haz the power
Committed patchset #5 (id:100001) as https://skia.googlesource.com/skia/+/3a6672ae0c95f24f873dca21424e060df9f9c3e5
5 years, 10 months ago (2015-02-13 23:12:56 UTC) #26
scroggo
> Motivation: test that these works on all possible bots and for all possible > ...
5 years, 10 months ago (2015-02-18 14:51:57 UTC) #28
mtklein
Yeah, I guess I didn't read the CL clearly. No clients run our unit tests ...
5 years, 10 months ago (2015-02-18 14:55:25 UTC) #29
hal.canary
On 2015/02/18 14:55:25, mtklein wrote: > Yeah, I guess I didn't read the CL clearly. ...
5 years, 10 months ago (2015-02-18 15:02:32 UTC) #30
djsollen
5 years, 10 months ago (2015-02-18 15:34:34 UTC) #31
djsollen
On 2015/02/18 15:34:34, djsollen wrote: Our Android bots should have C++11 support.
5 years, 10 months ago (2015-02-18 15:43:53 UTC) #32
djsollen
5 years, 10 months ago (2015-02-18 15:43:54 UTC) #33
Message was sent while issue was closed.
On 2015/02/18 15:34:34, djsollen wrote:

Our Android bots should have C++11 support.

Powered by Google App Engine
This is Rietveld 408576698