|
|
Created:
5 years, 10 months ago by hal.canary Modified:
5 years, 10 months ago CC:
reviews_skia.org, scroggo Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionC++11 Unit Test for RValue semantics.
Motivation: test that these works on all possible bots and for all possible clients (clients do run these unit tests, right?)
Dear clients: if this unit test fails, let us know!
BUG=skia:3427
Committed: https://skia.googlesource.com/skia/+/3a6672ae0c95f24f873dca21424e060df9f9c3e5
Patch Set 1 : 2015-02-13 (Friday) 16:15:17 EST #Patch Set 2 : 2015-02-13 (Friday) 17:54:58 EST #
Messages
Total messages: 33 (13 generated)
The CQ bit was checked by halcanary@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922043004/1
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2015-02-14 01:17 UTC
The CQ bit was unchecked by halcanary@google.com
The CQ bit was checked by halcanary@google.com
Patchset #1 (id:1) has been deleted
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922043004/20001
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2015-02-14 01:29 UTC
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GC...)
The CQ bit was checked by halcanary@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922043004/40001
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2015-02-14 03:06 UTC
The CQ bit was checked by halcanary@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922043004/60001
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2015-02-14 03:17 UTC
halcanary@google.com changed reviewers: + mtklein@google.com
ptal
The CQ bit was checked by halcanary@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/922043004/100001
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2015-02-14 04:56 UTC
lgtm
Patchset #4 (id:80001) has been deleted
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:40001) has been deleted
Message was sent while issue was closed.
Committed patchset #5 (id:100001) as https://skia.googlesource.com/skia/+/3a6672ae0c95f24f873dca21424e060df9f9c3e5
Message was sent while issue was closed.
scroggo@google.com changed reviewers: + scroggo@google.com
Message was sent while issue was closed.
> Motivation: test that these works on all possible bots and for all possible > clients (clients do run these unit tests, right?) Android framework build does not (we have bugs to start running them: skbug.com/2454 and b/19015688). Derek, does their build support this?
Message was sent while issue was closed.
Yeah, I guess I didn't read the CL clearly. No clients run our unit tests today. This doesn't test anything but our bots. If you want to see if you can use C++11 in Skia, use C++11 in Skia.
Message was sent while issue was closed.
On 2015/02/18 14:55:25, mtklein wrote: > Yeah, I guess I didn't read the CL clearly. No clients run our unit tests > today. This doesn't test anything but our bots. If you want to see if you can > use C++11 in Skia, use C++11 in Skia. A later CL will do that. (An upgraded version of SkAutoTUnref)
Message was sent while issue was closed.
Message was sent while issue was closed.
On 2015/02/18 15:34:34, djsollen wrote: Our Android bots should have C++11 support.
Message was sent while issue was closed.
On 2015/02/18 15:34:34, djsollen wrote: Our Android bots should have C++11 support. |