Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: sdk/lib/mirrors/mirrors.dart

Issue 922023002: Implement DeclarationMirror.location for all but ParameterMirrors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/mirrors/mirrors.dart
diff --git a/sdk/lib/mirrors/mirrors.dart b/sdk/lib/mirrors/mirrors.dart
index d16e62eecb7fc4e63e4518e7ffd4398b8c562fda..a52bc8802df41beef26cbbe2ef48327bdcf52979 100644
--- a/sdk/lib/mirrors/mirrors.dart
+++ b/sdk/lib/mirrors/mirrors.dart
@@ -286,9 +286,10 @@ abstract class DeclarationMirror implements Mirror {
bool get isTopLevel;
/**
- * The source location of this Dart language entity.
+ * The source location of this Dart language entity, or [:null:] if the
+ * entity is synthetic.
*
- * This operation is optional and may return [:null:].
+ * This operation is optional and may throw an [UnsupportedError].
*/
gbracha 2015/02/13 03:00:57 So we probably should tighten the specification fo
rmacnak 2015/02/13 20:46:34 A library might not have a 'library foo' declarati
SourceLocation get location;

Powered by Google App Engine
This is Rietveld 408576698