Implement DeclarationMirror.location for all but ParameterMirrors.

runtime/lib/mirrors_impl.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // VM-specific implementation of the dart:mirrors library.
 
 import "dart:collection" show UnmodifiableListView, UnmodifiableMapView;
 
 final emptyList = new UnmodifiableListView([]);
 final emptyMap = new UnmodifiableMapView({});
@@ skipping 62 matching lines @@
     buf.write('}');
   }
   if (found_optional_positional) {
     buf.write(']');
   }
   buf.write(') -> ');
   buf.write(_n(returnType.qualifiedName));
   return buf.toString();
 }
 
+SourceLocation _location(reflectee)
+    native "DeclarationMirror_location";
+
 List _metadata(reflectee)
     native 'DeclarationMirror_metadata';
 
 bool _subtypeTest(Type a, Type b)
     native 'TypeMirror_subtypeTest';
 
 bool _moreSpecificTest(Type a, Type b)
     native 'TypeMirror_moreSpecificTest';
 
 class _AccessorCacheAssociation {
@@ skipping 225 matching lines @@
   Symbol get qualifiedName => _computeQualifiedName(owner, simpleName);
   Symbol get constructorName => const Symbol('');
 
   TypeMirror get returnType => _target.type;
   List<ParameterMirror> get parameters {
     if (isGetter) return emptyList;
     return new UnmodifiableListView(
         [new _SyntheticSetterParameter(this, this._target)]);
   }
 
+  SourceLocation get location => null;
   List<InstanceMirror> get metadata => emptyList;
   String get source => null;
-  SourceLocation get location => null;
 }
 
 class _SyntheticSetterParameter implements ParameterMirror {
   final DeclarationMirror owner;
   final VariableMirror _target;
 
   _SyntheticSetterParameter(this.owner, this._target);
 
   Symbol get simpleName => _target.simpleName;
   Symbol get qualifiedName => _computeQualifiedName(owner, simpleName);
   TypeMirror get type => _target.type;
 
   bool get isOptional => false;
   bool get isNamed => false;
   bool get isStatic => false;
   bool get isTopLevel => false;
   bool get isConst => false;
   bool get isFinal => true;
   bool get isPrivate => false;
   bool get hasDefaultValue => false;
   InstanceMirror get defaultValue => null;
+  SourceLocation get location => null;
   List<InstanceMirror> get metadata => emptyList;
-  SourceLocation get location => throw new UnimplementedError();
 }
 
 abstract class _LocalObjectMirror extends _LocalMirror implements ObjectMirror {
   final _reflectee; // May be a MirrorReference or an ordinary object.
 
   _LocalObjectMirror(this._reflectee);
 
   InstanceMirror invoke(Symbol memberName,
                         List positionalArguments,
                         [Map<Symbol, dynamic> namedArguments]) {
@@ skipping 266 matching lines @@
       _owner = _library(_reflectee);
     }
     return _owner;
   }
 
   bool get isPrivate => _n(simpleName).startsWith('_');
 
   final bool isTopLevel = true;
 
   SourceLocation get location {
-    throw new UnimplementedError('ClassMirror.location is not implemented');
+    return _location(_reflectee);
   }
 
   ClassMirror _trueSuperclassField;
   ClassMirror get _trueSuperclass {
     if (_trueSuperclassField == null) {
       Type supertype = isOriginalDeclaration
           ? _supertype(_reflectedType)
           : _supertypeInstantiated(_reflectedType);
       if (supertype == null) {
         // Object has no superclass.
@@ skipping 386 matching lines @@
   Symbol _qualifiedName = null;
   Symbol get qualifiedName {
     if (_qualifiedName == null) {
       _qualifiedName = _computeQualifiedName(owner, simpleName);
     }
     return _qualifiedName;
   }
 
   bool get isPrivate => _n(simpleName).startsWith('_');
 
+  SourceLocation get location {
+    return _location(_reflectee);
+  }
+
   List<InstanceMirror> get metadata {
     // Get the metadata objects, convert them into InstanceMirrors using
     // reflect() and then make them into a Dart list.
     return new UnmodifiableListView(_metadata(_reflectee).map(reflect));
   }
 
   bool operator ==(other) {
     return this.runtimeType == other.runtimeType &&
            this._reflectee == other._reflectee;
   }
@@ skipping 12 matching lines @@
   DeclarationMirror get owner {
     if (_owner == null) {
       _owner = _TypeVariableMirror_owner(_reflectee).originalDeclaration;
     }
     return _owner;
   }
 
   bool get isStatic => false;
   bool get isTopLevel => false;
 
-  SourceLocation get location {
-    throw new UnimplementedError(
-        'TypeVariableMirror.location is not implemented');
-  }
-
   TypeMirror _upperBound = null;
   TypeMirror get upperBound {
     if (_upperBound == null) {
       _upperBound = reflectType(_TypeVariableMirror_upper_bound(_reflectee));
     }
     return _upperBound;
   }
 
   bool get hasReflectedType => false;
   Type get reflectedType {
@@ skipping 54 matching lines @@
   bool get isTopLevel => true;
 
   DeclarationMirror _owner;
   DeclarationMirror get owner {
     if (_owner == null) {
       _owner = _LocalClassMirror._library(_reflectee);
     }
     return _owner;
   }
 
-  SourceLocation get location {
-    throw new UnimplementedError('TypedefMirror.location is not implemented');
-  }
-
   TypeMirror _referent = null;
   TypeMirror get referent {
     if (_referent == null) {
       _referent = _nativeReferent(_reflectedType);
       _referent._instantiator = _reflectedType;
     }
     return _referent;
   }
 
   bool get hasReflectedType => !_isGenericDeclaration;
@@ skipping 85 matching lines @@
   // The simple name and the qualified name are the same for a library.
   Symbol get qualifiedName => simpleName;
 
   DeclarationMirror get owner => null;
 
   bool get isPrivate => false;
   bool get isTopLevel => false;
 
   Type get _instantiator => null;
 
-  SourceLocation get location {
-    throw new UnimplementedError('LibraryMirror.location is not implemented');
-  }
-
   Map<Symbol, DeclarationMirror> _declarations;
   Map<Symbol, DeclarationMirror> get declarations {
     if (_declarations != null) return _declarations;
     return _declarations =
         new UnmodifiableMapView<Symbol, DeclarationMirror>(_members);
   }
 
   Map<Symbol, Mirror> _cachedMembers;
   Map<Symbol, Mirror> get _members {
     if (_cachedMembers == null) {
       _cachedMembers = _makeMemberMap(_computeMembers(_reflectee));
     }
     return _cachedMembers;
   }
 
+  SourceLocation get location {
+    return _location(_reflectee);
+  }
+
   List<InstanceMirror> get metadata {
     // Get the metadata objects, convert them into InstanceMirrors using
     // reflect() and then make them into a Dart list.
     return new UnmodifiableListView(_metadata(_reflectee).map(reflect));
   }
 
   bool operator ==(other) {
     return this.runtimeType == other.runtimeType &&
            this._reflectee == other._reflectee;
   }
@@ skipping 97 matching lines @@
     }
     return _owner;
   }
 
   bool get isPrivate => _n(simpleName).startsWith('_') ||
                         _n(constructorName).startsWith('_');
 
   bool get isTopLevel => owner is LibraryMirror;
   bool get isSynthetic => false;
 
-  SourceLocation _location;
-  SourceLocation get location {
-    if (_location == null) {
-      _location = _MethodMirror_location(_reflectee);
-    }
-    return _location;
-  }
-
   Type get _instantiator {
     var o = owner;
     while (o is MethodMirror) o = o.owner;
     return o._instantiator;
   }
 
   TypeMirror _returnType = null;
   TypeMirror get returnType {
     if (_returnType == null) {
       if (isConstructor) {
@@ skipping 62 matching lines @@
       native "MethodMirror_owner";
 
   static dynamic _MethodMirror_return_type(reflectee, instantiator)
       native "MethodMirror_return_type";
 
   List<ParameterMirror> _MethodMirror_parameters(reflectee)
       native "MethodMirror_parameters";
 
   static String _MethodMirror_source(reflectee)
       native "MethodMirror_source";
-
-  static SourceLocation _MethodMirror_location(reflectee)
-      native "MethodMirror_location";
 }
 
 class _LocalVariableMirror extends _LocalDeclarationMirror
     implements VariableMirror {
   final DeclarationMirror owner;
   final bool isStatic;
   final bool isFinal;
   final bool isConst;
 
   _LocalVariableMirror(reflectee,
                        String simpleName,
                        this.owner,
                        this._type,
                        this.isStatic,
                        this.isFinal,
                        this.isConst)
       : super(reflectee, _s(simpleName));
 
   bool get isTopLevel => owner is LibraryMirror;
 
-  SourceLocation get location {
-    throw new UnimplementedError('VariableMirror.location is not implemented');
-  }
-
   Type get _instantiator {
     return owner._instantiator;
   }
 
   TypeMirror _type;
   TypeMirror get type {
     if (_type == null) {
        _type = reflectType(_VariableMirror_type(_reflectee, _instantiator));
     }
     return _type;
@@ skipping 37 matching lines @@
       return null;
     }
     if (_defaultValue == null) {
       _defaultValue = reflect(_defaultValueReflectee);
     }
     return _defaultValue;
   }
 
   bool get hasDefaultValue => _defaultValueReflectee != null;
 
+  SourceLocation get location {
+    throw new UnsupportedError("ParameterMirror.location unimplemented");
+  }
+
   List<InstanceMirror> get metadata {
     if (_unmirroredMetadata == null) return emptyList;
     return new UnmodifiableListView(_unmirroredMetadata.map(reflect));
   }
 
   Type get _instantiator {
     var o = owner;
     while (o is MethodMirror) o = o.owner;
     return o._instantiator;
   }
@@ skipping 17 matching lines @@
     implements TypeMirror, DeclarationMirror {
   final Symbol simpleName;
 
   _SpecialTypeMirror(String name) : simpleName = _s(name);
 
   bool get isPrivate => false;
   bool get isTopLevel => true;
 
   DeclarationMirror get owner => null;
 
+  SourceLocation get location => null;
   List<InstanceMirror> get metadata => emptyList;
 
   bool get hasReflectedType => simpleName == #dynamic;
   Type get reflectedType {
     if (simpleName == #dynamic) return dynamic;
     throw new UnsupportedError("void has no reflected type");
   }
 
   List<TypeVariableMirror> get typeVariables => emptyList;
   List<TypeMirror> get typeArguments => emptyList;
 
   bool get isOriginalDeclaration => true;
   TypeMirror get originalDeclaration => this;
 
-  SourceLocation get location {
-    throw new UnimplementedError('TypeMirror.location is not implemented');
-  }
-
   Symbol get qualifiedName => simpleName;
 
   // TODO(11955): Remove once dynamicType and voidType are canonical objects in
   // the object store.
   bool operator ==(other) {
     if (other is! _SpecialTypeMirror) {
       return false;
     }
     return this.simpleName == other.simpleName;
   }
@@ skipping 58 matching lines @@
     if (typeMirror == null) {
       typeMirror = makeLocalTypeMirror(key);
       _instanitationCache[key] = typeMirror;
       if (typeMirror is ClassMirror && !typeMirror._isGeneric) {
         _declarationCache[key] = typeMirror;
       }
     }
     return typeMirror;
   }
 }