Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 921993002: Implement the rest of the PPAPI examples in the GN build. (Closed)

Created:
5 years, 10 months ago by brettw
Modified:
5 years, 10 months ago
CC:
chromium-reviews, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ppapi_examples
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement the rest of the PPAPI examples in the GN build. This adds the "threading" example which was unreferenced in the GYP build, despite existing and compiling OK. Committed: https://crrev.com/2f79efe67a47c353ba79093d5117cae682523ad2 Cr-Commit-Position: refs/heads/master@{#316379}

Patch Set 1 #

Patch Set 2 : Fix GYP #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+323 lines, -93 lines) Patch
A ppapi/examples/2d/BUILD.gn View 1 chunk +44 lines, -0 lines 0 comments Download
M ppapi/examples/BUILD.gn View 1 chunk +27 lines, -1 line 0 comments Download
M ppapi/examples/audio/BUILD.gn View 1 chunk +1 line, -1 line 2 comments Download
A + ppapi/examples/audio_input/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
A + ppapi/examples/compositor/BUILD.gn View 1 chunk +7 lines, -4 lines 0 comments Download
A + ppapi/examples/crxfs/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
A + ppapi/examples/enumerate_devices/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
A + ppapi/examples/file_chooser/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
A + ppapi/examples/flash_topmost/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
A + ppapi/examples/font/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
A + ppapi/examples/gamepad/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
A + ppapi/examples/gles2/BUILD.gn View 1 chunk +5 lines, -4 lines 0 comments Download
A + ppapi/examples/gles2_spinning_cube/BUILD.gn View 1 chunk +7 lines, -4 lines 0 comments Download
A + ppapi/examples/ime/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
A + ppapi/examples/input/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
A + ppapi/examples/media_stream_audio/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
A + ppapi/examples/media_stream_video/BUILD.gn View 1 chunk +5 lines, -4 lines 0 comments Download
A + ppapi/examples/mouse_cursor/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
A + ppapi/examples/mouse_lock/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
A + ppapi/examples/printing/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
A + ppapi/examples/scaling/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
A + ppapi/examples/scripting/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
A ppapi/examples/stub/BUILD.gn View 1 chunk +33 lines, -0 lines 0 comments Download
A + ppapi/examples/threading/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
A ppapi/examples/url_loader/BUILD.gn View 1 chunk +33 lines, -0 lines 0 comments Download
A + ppapi/examples/video_capture/BUILD.gn View 1 chunk +5 lines, -4 lines 0 comments Download
A ppapi/examples/video_decode/BUILD.gn View 1 chunk +37 lines, -0 lines 0 comments Download
A + ppapi/examples/video_effects/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
M ppapi/lib/gl/gles2/BUILD.gn View 2 chunks +7 lines, -3 lines 0 comments Download
M ppapi/ppapi_tests.gypi View 1 32 chunks +44 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
brettw
Lots of files but trivial to review, I promise!
5 years, 10 months ago (2015-02-13 01:01:21 UTC) #2
dmichael (off chromium)
lgtm https://codereview.chromium.org/921993002/diff/20001/ppapi/examples/audio/BUILD.gn File ppapi/examples/audio/BUILD.gn (right): https://codereview.chromium.org/921993002/diff/20001/ppapi/examples/audio/BUILD.gn#newcode15 ppapi/examples/audio/BUILD.gn:15: } Not important, but it's weird that this ...
5 years, 10 months ago (2015-02-13 16:55:17 UTC) #3
brettw
https://codereview.chromium.org/921993002/diff/20001/ppapi/examples/audio/BUILD.gn File ppapi/examples/audio/BUILD.gn (right): https://codereview.chromium.org/921993002/diff/20001/ppapi/examples/audio/BUILD.gn#newcode15 ppapi/examples/audio/BUILD.gn:15: } On 2015/02/13 16:55:17, dmichael wrote: > Not important, ...
5 years, 10 months ago (2015-02-13 20:58:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/921993002/20001
5 years, 10 months ago (2015-02-14 04:20:14 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/25305)
5 years, 10 months ago (2015-02-14 05:35:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/921993002/20001
5 years, 10 months ago (2015-02-14 05:48:28 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-14 06:54:25 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-14 06:55:00 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/2f79efe67a47c353ba79093d5117cae682523ad2
Cr-Commit-Position: refs/heads/master@{#316379}

Powered by Google App Engine
This is Rietveld 408576698