mac: Add profiling for VideoCaptureDeviceFactoryMac::EnumerateDeviceNames

mac: Add profiling for VideoCaptureDeviceFactoryMac::EnumerateDeviceNames

BUG=458397
Committed: https://crrev.com/ebdced2d6f75498f4cd53c1771cc49e2a4d026e4
Cr-Commit-Position: refs/heads/master@{#316309}

[erikchen, 2015-02-13 02:27:10]

erikchen@chromium.org changed reviewers:
+ vadimt@chromium.org

[erikchen, 2015-02-13 02:27:10]

vadimt: Please review.

[vadimt, 2015-02-13 02:29:26]

lgtm

[erikchen, 2015-02-13 02:39:11]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2015-02-13 02:40:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/921983004/1

[commit-bot: I haz the power, 2015-02-13 02:45:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-13 02:45:26]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[erikchen, 2015-02-13 02:50:37]

erikchen@chromium.org changed reviewers:
+ mcasas@chromium.org

[erikchen, 2015-02-13 02:50:38]

mcasas: Looking for an OWNER review.

[mcasas, 2015-02-13 16:53:10]

LGTM, see comments below.

https://codereview.chromium.org/921983004/diff/1/media/video/capture/mac/vide...
File media/video/capture/mac/video_capture_device_factory_mac.mm (right):

https://codereview.chromium.org/921983004/diff/1/media/video/capture/mac/vide...
media/video/capture/mac/video_capture_device_factory_mac.mm:48: //
TODO(erikchen): Remove ScopedTracker below once crbug.com/458397 is fixed.
Nit: Add http:// in front of crbug.com. Also below.

https://codereview.chromium.org/921983004/diff/1/media/video/capture/mac/vide...
media/video/capture/mac/video_capture_device_factory_mac.mm:115:
DCHECK(thread_checker_.CalledOnValidThread());
Shouldn't you check for jankiness here as well?
Video capture device enumeration uses either QTKit
xor AVFoundation based on a somewhat involved
casuistic, and this is the AVFoundation path.

[erikchen, 2015-02-13 21:48:28]

New patchsets have been uploaded after l-g-t-m from
vadimt@chromium.org,mcasas@chromium.org

[erikchen, 2015-02-13 21:53:44]

https://codereview.chromium.org/921983004/diff/1/media/video/capture/mac/vide...
File media/video/capture/mac/video_capture_device_factory_mac.mm (right):

https://codereview.chromium.org/921983004/diff/1/media/video/capture/mac/vide...
media/video/capture/mac/video_capture_device_factory_mac.mm:48: //
TODO(erikchen): Remove ScopedTracker below once crbug.com/458397 is fixed.
On 2015/02/13 16:53:09, mcasas wrote:
> Nit: Add http:// in front of http://crbug.com. Also below.

Done.

https://codereview.chromium.org/921983004/diff/1/media/video/capture/mac/vide...
media/video/capture/mac/video_capture_device_factory_mac.mm:115:
DCHECK(thread_checker_.CalledOnValidThread());
On 2015/02/13 16:53:09, mcasas wrote:
> Shouldn't you check for jankiness here as well?
> Video capture device enumeration uses either QTKit
> xor AVFoundation based on a somewhat involved
> casuistic, and this is the AVFoundation path.

The particular source of jank that I'm tracking down has already been isolated
to the EnumerateDevicesUsingQTKit path. I just wanted to add a little bit more
granularity before passing off the task to someone who better knows the code.

That being said, there's no harm to adding some more profiling here - it's
possible that this path also has jankiness.

[erikchen, 2015-02-13 21:53:50]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2015-02-13 21:54:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/921983004/20001

[commit-bot: I haz the power, 2015-02-13 22:32:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-13 22:33:23]

Patchset 2 (id:??) landed as
https://crrev.com/ebdced2d6f75498f4cd53c1771cc49e2a4d026e4
Cr-Commit-Position: refs/heads/master@{#316309}