Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Side by Side Diff: third_party/sqlite/sqlite.gyp

Issue 921983002: [sql] Enable disabled clang warnings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/sqlite/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'use_system_sqlite%': 0, 7 'use_system_sqlite%': 0,
8 'required_sqlite_version': '3.6.1', 8 'required_sqlite_version': '3.6.1',
9 }, 9 },
10 'target_defaults': { 10 'target_defaults': {
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 ], 126 ],
127 'direct_dependent_settings': { 127 'direct_dependent_settings': {
128 'include_dirs': [ 128 'include_dirs': [
129 '.', 129 '.',
130 '../..', 130 '../..',
131 ], 131 ],
132 }, 132 },
133 'msvs_disabled_warnings': [ 133 'msvs_disabled_warnings': [
134 4018, 4244, 4267, 134 4018, 4244, 4267,
135 ], 135 ],
136 'variables': {
137 'clang_warning_flags': [
138 # sqlite does `if (*a++ && *b++);` in a non-buggy way.
139 '-Wno-empty-body',
140 # sqlite has some `unsigned < 0` checks.
141 '-Wno-tautological-compare',
142 # Needed because we don't have this commit yet:
143 # https://github.com/mackyle/sqlite/commit/25df0fa050dcc9be7fb937b 8e25be24049b3fef0
144 '-Wno-pointer-bool-conversion',
145 ],
146 },
147 'conditions': [ 136 'conditions': [
148 ['OS=="linux"', { 137 ['OS=="linux"', {
149 'link_settings': { 138 'link_settings': {
150 'libraries': [ 139 'libraries': [
151 '-ldl', 140 '-ldl',
152 ], 141 ],
153 }, 142 },
154 }], 143 }],
155 ['OS == "mac" or OS == "ios"', { 144 ['OS == "mac" or OS == "ios"', {
156 'link_settings': { 145 'link_settings': {
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
244 '../icu/icu.gyp:icuuc', 233 '../icu/icu.gyp:icuuc',
245 ], 234 ],
246 'sources': [ 235 'sources': [
247 'src/ext/icu/icu.c', 236 'src/ext/icu/icu.c',
248 ], 237 ],
249 }, 238 },
250 ], 239 ],
251 }], 240 }],
252 ], 241 ],
253 } 242 }
OLDNEW
« no previous file with comments | « third_party/sqlite/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698