Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: third_party/sqlite/BUILD.gn

Issue 921983002: [sql] Enable disabled clang warnings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/sqlite/sqlite.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 config("sqlite_config") { 5 config("sqlite_config") {
6 include_dirs = [ "." ] 6 include_dirs = [ "." ]
7 } 7 }
8 8
9 source_set("sqlite") { 9 source_set("sqlite") {
10 sources = [ 10 sources = [
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 } else if (is_android) { 81 } else if (is_android) {
82 defines += [ 82 defines += [
83 "SQLITE_DEFAULT_JOURNAL_SIZE_LIMIT=1048576", 83 "SQLITE_DEFAULT_JOURNAL_SIZE_LIMIT=1048576",
84 "SQLITE_DEFAULT_AUTOVACUUM=1", 84 "SQLITE_DEFAULT_AUTOVACUUM=1",
85 "SQLITE_TEMP_STORE=3", 85 "SQLITE_TEMP_STORE=3",
86 "SQLITE_ENABLE_FTS3_BACKWARDS", 86 "SQLITE_ENABLE_FTS3_BACKWARDS",
87 "DSQLITE_DEFAULT_FILE_FORMAT=4", 87 "DSQLITE_DEFAULT_FILE_FORMAT=4",
88 ] 88 ]
89 } 89 }
90 90
91 if (is_clang) {
92 cflags += [
93 # sqlite does `if (*a++ && *b++);` in a non-buggy way.
94 "-Wno-empty-body",
95
96 # sqlite has some `unsigned < 0` checks.
97 "-Wno-tautological-compare",
98
99 # Needed because we don't have this commit yet:
100 # https://github.com/mackyle/sqlite/commit/25df0fa050dcc9be7fb937b8e25be24 049b3fef0
101 "-Wno-pointer-bool-conversion",
102 ]
103 }
104
105 public_configs = [ ":sqlite_config" ] 91 public_configs = [ ":sqlite_config" ]
106 92
107 deps = [ 93 deps = [
108 "//third_party/icu", 94 "//third_party/icu",
109 ] 95 ]
110 } 96 }
111 97
112 if (is_linux) { 98 if (is_linux) {
113 executable("sqlite_shell") { 99 executable("sqlite_shell") {
114 sources = [ 100 sources = [
(...skipping 14 matching lines...) Expand all
129 if (is_ios) { 115 if (is_ios) {
130 source_set("sqlite_regexp") { 116 source_set("sqlite_regexp") {
131 sources = [ 117 sources = [
132 "src/ext/icu/icu.c", 118 "src/ext/icu/icu.c",
133 ] 119 ]
134 deps = [ 120 deps = [
135 "//third_party/icu", 121 "//third_party/icu",
136 ] 122 ]
137 } 123 }
138 } 124 }
OLDNEW
« no previous file with comments | « no previous file | third_party/sqlite/sqlite.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698