Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 921983002: [sql] Enable disabled clang warnings. (Closed)

Created:
5 years, 10 months ago by Scott Hess - ex-Googler
Modified:
5 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sql] Enable disabled clang warnings. New version of SQLite can handle them. I suspect probably due to Apple support. no-pointer-bool-conversion no-empty-body no-tautological-compare BUG=none R=thakis@chromium.org Committed: https://crrev.com/03a5623bd68b1058603ef3b6a3c077a45d5f0ed2 Cr-Commit-Position: refs/heads/master@{#316134}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -25 lines) Patch
M third_party/sqlite/BUILD.gn View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/sqlite/sqlite.gyp View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Scott Hess - ex-Googler
As long as we're in there...
5 years, 10 months ago (2015-02-13 00:32:50 UTC) #1
Scott Hess - ex-Googler
On 2015/02/13 00:32:50, Scott Hess wrote: > As long as we're in there... My test ...
5 years, 10 months ago (2015-02-13 00:34:04 UTC) #2
Nico
lgtm, the trybots should catch any issues as we build with -Werror (except if there's ...
5 years, 10 months ago (2015-02-13 01:31:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/921983002/1
5 years, 10 months ago (2015-02-13 01:33:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-13 02:29:32 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 02:30:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/03a5623bd68b1058603ef3b6a3c077a45d5f0ed2
Cr-Commit-Position: refs/heads/master@{#316134}

Powered by Google App Engine
This is Rietveld 408576698