Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 921953002: Split apart the PPAPI GN targets (Closed)

Created:
5 years, 10 months ago by brettw
Modified:
5 years, 10 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, chromoting-reviews_chromium.org, yusukes+watch_chromium.org, eme-reviews_chromium.org, binji+watch_chromium.org, tzik, jam, raymes+watch_chromium.org, feature-media-reviews_chromium.org, teravest+watch_chromium.org, darin-cc_chromium.org, dcheng, bradnelson+warch_chromium.org, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split apart the PPAPI GN targets This puts BUILD files in the corresponding directories without duplicate names. Adds a template for ppapi examples and writes the build for one example. I only did one at this point to test the infrastructure without making this patch too large. NOPRESUBMIT=true Committed: https://crrev.com/f7eb6caac05a31363eefa30cad2d5aa2198d64ea Cr-Commit-Position: refs/heads/master@{#316352}

Patch Set 1 #

Patch Set 2 : #

Total comments: 7

Patch Set 3 : #

Patch Set 4 : merge #

Patch Set 5 : chromeos gn bot #

Patch Set 6 : #

Patch Set 7 : fix #

Patch Set 8 : fix component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+958 lines, -847 lines) Patch
M BUILD.gn View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/BUILD.gn View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/BUILD.gn View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M components/pdf/renderer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/ppapi_plugin/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/BUILD.gn View 2 chunks +9 lines, -8 lines 0 comments Download
M media/cdm/ppapi/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M pdf/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/BUILD.gn View 1 2 3 1 chunk +5 lines, -785 lines 0 comments Download
A + ppapi/c/BUILD.gn View 1 2 3 4 5 6 1 chunk +7 lines, -0 lines 0 comments Download
A ppapi/cpp/BUILD.gn View 1 1 chunk +26 lines, -0 lines 0 comments Download
A + ppapi/cpp/private/BUILD.gn View 1 1 chunk +8 lines, -1 line 0 comments Download
A + ppapi/examples/BUILD.gn View 1 1 chunk +8 lines, -1 line 0 comments Download
A + ppapi/examples/audio/BUILD.gn View 1 1 chunk +9 lines, -8 lines 0 comments Download
A ppapi/examples/ppapi_example.gni View 1 1 chunk +28 lines, -0 lines 0 comments Download
A ppapi/host/BUILD.gn View 1 1 chunk +44 lines, -0 lines 0 comments Download
A + ppapi/lib/gl/gles2/BUILD.gn View 1 1 chunk +11 lines, -8 lines 0 comments Download
M ppapi/ppapi_cpp.gypi View 1 3 4 chunks +4 lines, -4 lines 0 comments Download
M ppapi/ppapi_gl.gypi View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/ppapi_internal.gyp View 1 3 3 chunks +3 lines, -3 lines 0 comments Download
A ppapi/ppapi_sources.gni View 1 1 chunk +11 lines, -0 lines 0 comments Download
M ppapi/ppapi_tests.gypi View 1 3 1 chunk +2 lines, -1 line 0 comments Download
A ppapi/proxy/BUILD.gn View 1 2 3 4 5 6 1 chunk +350 lines, -0 lines 0 comments Download
A ppapi/shared_impl/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +215 lines, -0 lines 0 comments Download
A ppapi/thunk/BUILD.gn View 1 2 3 4 5 6 1 chunk +190 lines, -0 lines 0 comments Download
M remoting/client/plugin/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/widevine/cdm/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 24 (11 generated)
dmichael (off chromium)
lgtm https://codereview.chromium.org/921953002/diff/20001/chrome/renderer/BUILD.gn File chrome/renderer/BUILD.gn (right): https://codereview.chromium.org/921953002/diff/20001/chrome/renderer/BUILD.gn#newcode83 chrome/renderer/BUILD.gn:83: "//ppapi/shared_impl", tiny nit: these were sorted in the ...
5 years, 10 months ago (2015-02-12 23:44:33 UTC) #2
brettw
https://codereview.chromium.org/921953002/diff/20001/chrome/renderer/BUILD.gn File chrome/renderer/BUILD.gn (right): https://codereview.chromium.org/921953002/diff/20001/chrome/renderer/BUILD.gn#newcode83 chrome/renderer/BUILD.gn:83: "//ppapi/shared_impl", On 2015/02/12 23:44:33, dmichael wrote: > tiny nit: ...
5 years, 10 months ago (2015-02-13 00:20:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/921953002/60001
5 years, 10 months ago (2015-02-13 21:29:23 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/8258)
5 years, 10 months ago (2015-02-13 21:35:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/921953002/100001
5 years, 10 months ago (2015-02-13 21:43:16 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/42499)
5 years, 10 months ago (2015-02-13 21:49:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/921953002/120001
5 years, 10 months ago (2015-02-13 22:00:36 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/42724)
5 years, 10 months ago (2015-02-13 22:27:45 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/921953002/140001
5 years, 10 months ago (2015-02-14 00:02:03 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/25205)
5 years, 10 months ago (2015-02-14 01:00:34 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/921953002/140001
5 years, 10 months ago (2015-02-14 01:02:06 UTC) #22
commit-bot: I haz the power
Committed patchset #8 (id:140001)
5 years, 10 months ago (2015-02-14 01:37:39 UTC) #23
commit-bot: I haz the power
5 years, 10 months ago (2015-02-14 01:38:12 UTC) #24
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/f7eb6caac05a31363eefa30cad2d5aa2198d64ea
Cr-Commit-Position: refs/heads/master@{#316352}

Powered by Google App Engine
This is Rietveld 408576698