Move GetProcessIntegrityLevel to file_info.h and remove the handle argument.

Move GetProcessIntegrityLevel to file_info.h and remove the handle argument.

BUG=417532
Committed: https://crrev.com/6c690f1c2e035deda117ac13e6d5a23f4be6e3c6
Cr-Commit-Position: refs/heads/master@{#316242}

[rvargas (doing something else), 2015-02-12 22:47:11]

rvargas@chromium.org changed reviewers:
+ cpu@chromium.org

[rvargas (doing something else), 2015-02-12 22:47:12]

https://codereview.chromium.org/921913002/diff/1/chrome/browser/process_singl...
File chrome/browser/process_singleton_win.cc (left):

https://codereview.chromium.org/921913002/diff/1/chrome/browser/process_singl...
chrome/browser/process_singleton_win.cc:189: #if defined(USE_AURA)
I still see 460 uses of this definition.

https://codereview.chromium.org/921913002/diff/1/rlz/win/lib/process_info.cc
File rlz/win/lib/process_info.cc (right):

https://codereview.chromium.org/921913002/diff/1/rlz/win/lib/process_info.cc#...
rlz/win/lib/process_info.cc:105: if (level != base::INTEGRITY_UNKNOWN) {
This looks a little weird but I'm strictly following the original behavior.

Note that has_rights is false even if elevation == TokenElevationTypeFull if
there's an issue with GetCurrentProcessIntegrityLevel.

[cpu_(ooo_6.6-7.5), 2015-02-13 00:25:12]

https://codereview.chromium.org/921913002/diff/1/chrome/browser/process_singl...
File chrome/browser/process_singleton_win.cc (left):

https://codereview.chromium.org/921913002/diff/1/chrome/browser/process_singl...
chrome/browser/process_singleton_win.cc:189: #if defined(USE_AURA)
On 2015/02/12 22:47:12, rvargas wrote:
> I still see 460 uses of this definition.

Mac is not yet aura so I hope that is the bulk of it. :(

https://codereview.chromium.org/921913002/diff/1/chrome/browser/process_singl...
chrome/browser/process_singleton_win.cc:199: if
(base::win::IsProcessImmersive(base::GetCurrentProcessHandle()))
I believe IsProcessImmersive can be removed from base altogether.

https://codereview.chromium.org/921913002/diff/1/rlz/win/lib/process_info.cc
File rlz/win/lib/process_info.cc (right):

https://codereview.chromium.org/921913002/diff/1/rlz/win/lib/process_info.cc#...
rlz/win/lib/process_info.cc:105: if (level != base::INTEGRITY_UNKNOWN) {
On 2015/02/12 22:47:12, rvargas wrote:
> This looks a little weird but I'm strictly following the original behavior.
> 
> Note that has_rights is false even if elevation == TokenElevationTypeFull if
> there's an issue with GetCurrentProcessIntegrityLevel.

Acknowledged.

[cpu_(ooo_6.6-7.5), 2015-02-13 02:39:46]

lgtm w/ comment

https://codereview.chromium.org/921913002/diff/1/base/process/process_info_wi...
File base/process/process_info_win.cc (right):

https://codereview.chromium.org/921913002/diff/1/base/process/process_info_wi...
base/process/process_info_win.cc:63: 
use c++ style casts.

[rvargas (doing something else), 2015-02-13 02:49:09]

Thanks

https://codereview.chromium.org/921913002/diff/1/base/process/process_info_wi...
File base/process/process_info_win.cc (right):

https://codereview.chromium.org/921913002/diff/1/base/process/process_info_wi...
base/process/process_info_win.cc:63: 
On 2015/02/13 02:39:46, cpu wrote:
> use c++ style casts.

arrggg. Sorry about that, I meant to fix it but forgot.

[rvargas (doing something else), 2015-02-13 02:53:19]

https://codereview.chromium.org/921913002/diff/1/chrome/browser/process_singl...
File chrome/browser/process_singleton_win.cc (left):

https://codereview.chromium.org/921913002/diff/1/chrome/browser/process_singl...
chrome/browser/process_singleton_win.cc:199: if
(base::win::IsProcessImmersive(base::GetCurrentProcessHandle()))
On 2015/02/13 00:25:12, cpu wrote:
> I believe IsProcessImmersive can be removed from base altogether. 

There are still two callers and I'm not sure it is aura only.

[rvargas (doing something else), 2015-02-13 02:55:59]

New patchsets have been uploaded after l-g-t-m from cpu@chromium.org

[cpu_(ooo_6.6-7.5), 2015-02-13 03:20:41]

lgtm

[rvargas (doing something else), 2015-02-13 18:03:03]

The CQ bit was checked by rvargas@chromium.org

[commit-bot: I haz the power, 2015-02-13 18:03:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/921913002/20001

[commit-bot: I haz the power, 2015-02-13 18:08:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-13 18:09:08]

Patchset 2 (id:??) landed as
https://crrev.com/6c690f1c2e035deda117ac13e6d5a23f4be6e3c6
Cr-Commit-Position: refs/heads/master@{#316242}