Issue 921903002: Add DartController and friends

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 921903002: Add DartController and friends (Closed)

Created:
5 years, 10 months ago by abarth-chromium

Modified:
5 years, 10 months ago

Reviewers:
rafaelw

CC:
esprehn, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Add DartController and friends This CL adds the DartController and associated classes. These classes let you load and execute dart code. R=rafaelw@chromium.org BUG=454613 Committed: https://chromium.googlesource.com/external/mojo/+/bfebc498825393fb714d26b10a988860c3a0fcfe

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+791 lines, -0 lines)			Patch
A	sky/engine/core/script/dart_controller.h	View		1 chunk	+49 lines, -0 lines	0 comments	Download
A	sky/engine/core/script/dart_controller.cc	View		1 chunk	+270 lines, -0 lines	0 comments	Download
A	sky/engine/core/script/dart_dependency_catcher.h	View		1 chunk	+37 lines, -0 lines	0 comments	Download
A	sky/engine/core/script/dart_dependency_catcher.cc	View		1 chunk	+24 lines, -0 lines	0 comments	Download
A	sky/engine/core/script/dart_loader.h	View	1	1 chunk	+70 lines, -0 lines	0 comments	Download
A	sky/engine/core/script/dart_loader.cc	View		1 chunk	+265 lines, -0 lines	0 comments	Download
A	sky/engine/core/script/dom_dart_state.h	View		1 chunk	+39 lines, -0 lines	0 comments	Download
A	sky/engine/core/script/dom_dart_state.cc	View		1 chunk	+37 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

rafaelw

lgtm. maybe add a TODO in loader to somehow de-crazify this code.

5 years, 10 months ago (2015-02-12 21:29:44 UTC) #2

abarth-chromium

5 years, 10 months ago (2015-02-12 21:34:49 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
bfebc498825393fb714d26b10a988860c3a0fcfe (presubmit successful).