Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
921873003:
Add x86/x64 upload support (Closed)
|
Created:
5 years, 10 months ago by haltonhuo Modified:
5 years, 10 months ago CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd x86/x64 upload support
BUG=458409
Patch Set 1 #
Messages
Total messages: 9 (1 generated)
halton.huo@intel.com changed reviewers: + jamesr@chromium.org, qsr@chromium.org
PTAL
I think we're OK with just android arm for now. We have no bots for android x86/64.
On 2015/02/13 04:06:24, jamesr wrote: > I think we're OK with just android arm for now. We have no bots for android > x86/64. jamesr, as Intel employer, I'm starting enabling the mojo for x86 and x64 build. qsr has reviewed and landed several CLs from me. And not sure if I'm missing, there is no x86/x64 bots for chromium android, but the related are keeping accepted.
On 2015/02/13 04:39:08, haltonhuo wrote: > On 2015/02/13 04:06:24, jamesr wrote: > > I think we're OK with just android arm for now. We have no bots for android > > x86/64. > > jamesr, as Intel employer, I'm starting enabling the mojo for x86 and x64 build. > qsr has reviewed and landed several CLs from me. > > And not sure if I'm missing, there is no x86/x64 bots for chromium android, but > the related are keeping accepted. The issue that James is speaking about is that we have no bot in chromium that would build the artifact you want to upload.
On 2015/02/13 13:47:17, qsr wrote: > On 2015/02/13 04:39:08, haltonhuo wrote: > > On 2015/02/13 04:06:24, jamesr wrote: > > > I think we're OK with just android arm for now. We have no bots for android > > > x86/64. > > > > jamesr, as Intel employer, I'm starting enabling the mojo for x86 and x64 > build. > > qsr has reviewed and landed several CLs from me. > > > > And not sure if I'm missing, there is no x86/x64 bots for chromium android, > but > > the related are keeping accepted. > > The issue that James is speaking about is that we have no bot in chromium that > would build the artifact you want to upload. Can I understand you normally upload the network_service binaries built from buildbot? Is that possible to upload from developer build? From mojo log, the network_service mojo files were ever built from source, would that solution be considered back?
On 2015/02/13 16:13:36, haltonhuo wrote: > On 2015/02/13 13:47:17, qsr wrote: > > On 2015/02/13 04:39:08, haltonhuo wrote: > > > On 2015/02/13 04:06:24, jamesr wrote: > > > > I think we're OK with just android arm for now. We have no bots for > android > > > > x86/64. > > > > > > jamesr, as Intel employer, I'm starting enabling the mojo for x86 and x64 > > build. > > > qsr has reviewed and landed several CLs from me. > > > > > > And not sure if I'm missing, there is no x86/x64 bots for chromium android, > > but > > > the related are keeping accepted. > > > > The issue that James is speaking about is that we have no bot in chromium > that > > would build the artifact you want to upload. > > Can I understand you normally upload the network_service binaries built from > buildbot? Is that possible to upload from developer build? This script exists so buildbots can upload artifacts into our google storage bucket. From a developer build you are free to upload binaries to any location you like, but you won't have access to this particular storage bucket so there's not much point in using this script. > > From mojo log, the network_service mojo files were ever built from source, would > that solution be considered back? You can build from source and upload to anywhere you want. We won't accept patches to this script for configurations we are not maintaining infrastructure for.
On 2015/02/13 19:13:23, jamesr wrote: > On 2015/02/13 16:13:36, haltonhuo wrote: > > On 2015/02/13 13:47:17, qsr wrote: > > > On 2015/02/13 04:39:08, haltonhuo wrote: > > > > On 2015/02/13 04:06:24, jamesr wrote: > > > > > I think we're OK with just android arm for now. We have no bots for > > android > > > > > x86/64. > > > > > > > > jamesr, as Intel employer, I'm starting enabling the mojo for x86 and x64 > > > build. > > > > qsr has reviewed and landed several CLs from me. > > > > > > > > And not sure if I'm missing, there is no x86/x64 bots for chromium > android, > > > but > > > > the related are keeping accepted. > > > > > > The issue that James is speaking about is that we have no bot in chromium > > that > > > would build the artifact you want to upload. > > > > Can I understand you normally upload the network_service binaries built from > > buildbot? Is that possible to upload from developer build? > > This script exists so buildbots can upload artifacts into our google storage > bucket. From a developer build you are free to upload binaries to any location > you like, but you won't have access to this particular storage bucket so there's > not much point in using this script. > > > > > From mojo log, the network_service mojo files were ever built from source, > would > > that solution be considered back? > > You can build from source and upload to anywhere you want. We won't accept > patches to this script for configurations we are not maintaining infrastructure > for. Quite understood your situation. I'm drafting a email to qsr to find possible solution to make everyone happy.
On 2015/02/15 06:11:00, haltonhuo wrote: > On 2015/02/13 19:13:23, jamesr wrote: > > On 2015/02/13 16:13:36, haltonhuo wrote: > > > On 2015/02/13 13:47:17, qsr wrote: > > > > On 2015/02/13 04:39:08, haltonhuo wrote: > > > > > On 2015/02/13 04:06:24, jamesr wrote: > > > > > > I think we're OK with just android arm for now. We have no bots for > > > android > > > > > > x86/64. > > > > > > > > > > jamesr, as Intel employer, I'm starting enabling the mojo for x86 and > x64 > > > > build. > > > > > qsr has reviewed and landed several CLs from me. > > > > > > > > > > And not sure if I'm missing, there is no x86/x64 bots for chromium > > android, > > > > but > > > > > the related are keeping accepted. > > > > > > > > The issue that James is speaking about is that we have no bot in chromium > > > that > > > > would build the artifact you want to upload. > > > > > > Can I understand you normally upload the network_service binaries built from > > > buildbot? Is that possible to upload from developer build? > > > > This script exists so buildbots can upload artifacts into our google storage > > bucket. From a developer build you are free to upload binaries to any > location > > you like, but you won't have access to this particular storage bucket so > there's > > not much point in using this script. > > > > > > > > From mojo log, the network_service mojo files were ever built from source, > > would > > > that solution be considered back? > > > > You can build from source and upload to anywhere you want. We won't accept > > patches to this script for configurations we are not maintaining > infrastructure > > for. > > Quite understood your situation. I'm drafting a email to qsr to find possible > solution to make everyone happy. Close this CL since it is resolved with https://codereview.chromium.org/921053003/ by adding a parameter. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||
