Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 921863002: Add testing resources from SkyDart branch (Closed)

Created:
5 years, 10 months ago by abarth-chromium
Modified:
5 years, 10 months ago
Reviewers:
zra, eseidel
CC:
esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add testing resources from SkyDart branch These packages come from Dart's pub system. I've removed files specific to dart:html and updated "package:" imports to use relative URLs. R=eseidel@chromium.org BUG=454613 Committed: https://chromium.googlesource.com/external/mojo/+/c7c2b7c918ac6a59a32f0e58832c2fb587e0afde

Patch Set 1 #

Patch Set 2 : restore-run-after-display #

Patch Set 3 : move to third_party #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6867 lines, -0 lines) Patch
A sky/tests/resources/third_party/matcher/matcher.dart View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/matcher/mirror_matchers.dart View 1 2 1 chunk +79 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/matcher/src/core_matchers.dart View 1 2 1 chunk +656 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/matcher/src/description.dart View 1 2 1 chunk +68 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/matcher/src/error_matchers.dart View 1 2 1 chunk +97 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/matcher/src/expect.dart View 1 2 1 chunk +177 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/matcher/src/future_matchers.dart View 1 2 1 chunk +75 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/matcher/src/interfaces.dart View 1 2 1 chunk +60 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/matcher/src/iterable_matchers.dart View 1 2 1 chunk +267 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/matcher/src/map_matchers.dart View 1 2 1 chunk +61 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/matcher/src/numeric_matchers.dart View 1 2 1 chunk +202 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/matcher/src/operator_matchers.dart View 1 2 1 chunk +113 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/matcher/src/pretty_print.dart View 1 2 1 chunk +152 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/matcher/src/prints_matcher.dart View 1 2 1 chunk +73 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/matcher/src/string_matchers.dart View 1 2 1 chunk +201 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/matcher/src/throws_matcher.dart View 1 2 1 chunk +112 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/matcher/src/throws_matchers.dart View 1 2 1 chunk +44 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/matcher/src/util.dart View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/path/path.dart View 1 2 1 chunk +381 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/path/src/characters.dart View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/path/src/context.dart View 1 2 1 chunk +559 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/path/src/internal_style.dart View 1 2 1 chunk +65 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/path/src/parsed_path.dart View 1 2 1 chunk +183 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/path/src/path_exception.dart View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/path/src/style.dart View 1 2 1 chunk +88 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/path/src/style/posix.dart View 1 2 1 chunk +64 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/path/src/style/url.dart View 1 2 1 chunk +64 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/path/src/style/windows.dart View 1 2 1 chunk +125 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/path/src/utils.dart View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/stack_trace/src/chain.dart View 1 2 1 chunk +188 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/stack_trace/src/frame.dart View 1 2 1 chunk +288 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/stack_trace/src/lazy_trace.dart View 1 2 1 chunk +36 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/stack_trace/src/stack_zone_specification.dart View 1 2 1 chunk +241 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/stack_trace/src/trace.dart View 1 2 1 chunk +248 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/stack_trace/src/utils.dart View 1 2 1 chunk +36 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/stack_trace/src/vm_trace.dart View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/stack_trace/stack_trace.dart View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/unittest/compact_vm_config.dart View 1 2 1 chunk +214 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/unittest/src/configuration.dart View 1 2 1 chunk +69 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/unittest/src/expected_function.dart View 1 2 1 chunk +203 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/unittest/src/group_context.dart View 1 2 1 chunk +75 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/unittest/src/internal_test_case.dart View 1 2 1 chunk +227 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/unittest/src/simple_configuration.dart View 1 2 1 chunk +207 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/unittest/src/test_case.dart View 1 2 1 chunk +55 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/unittest/src/test_environment.dart View 1 2 1 chunk +74 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/unittest/src/utils.dart View 1 2 1 chunk +51 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/unittest/unittest.dart View 1 2 1 chunk +442 lines, -0 lines 0 comments Download
A sky/tests/resources/third_party/unittest/vm_config.dart View 1 2 1 chunk +65 lines, -0 lines 0 comments Download
A sky/tests/resources/unit.dart View 1 chunk +20 lines, -0 lines 2 comments Download

Messages

Total messages: 9 (1 generated)
abarth-chromium
5 years, 10 months ago (2015-02-12 19:25:31 UTC) #1
eseidel
Do we need/want to be copying matcher from Dart?
5 years, 10 months ago (2015-02-12 19:29:12 UTC) #3
eseidel
Maybe these should be in a third_party? which we'll later make auto-downloaded instead of checked ...
5 years, 10 months ago (2015-02-12 19:30:44 UTC) #4
eseidel
lgtm https://codereview.chromium.org/921863002/diff/40001/sky/tests/resources/unit.dart File sky/tests/resources/unit.dart (right): https://codereview.chromium.org/921863002/diff/40001/sky/tests/resources/unit.dart#newcode1 sky/tests/resources/unit.dart:1: import "../resources/unittest/unittest.dart"; Is this still right?
5 years, 10 months ago (2015-02-12 20:19:57 UTC) #5
abarth-chromium
https://codereview.chromium.org/921863002/diff/40001/sky/tests/resources/unit.dart File sky/tests/resources/unit.dart (right): https://codereview.chromium.org/921863002/diff/40001/sky/tests/resources/unit.dart#newcode1 sky/tests/resources/unit.dart:1: import "../resources/unittest/unittest.dart"; On 2015/02/12 at 20:19:57, eseidel wrote: > ...
5 years, 10 months ago (2015-02-12 20:22:43 UTC) #6
abarth-chromium
Committed patchset #3 (id:40001) manually as c7c2b7c918ac6a59a32f0e58832c2fb587e0afde (presubmit successful).
5 years, 10 months ago (2015-02-12 20:23:15 UTC) #7
zra
On 2015/02/12 19:30:44, eseidel wrote: > Maybe these should be in a third_party? which we'll ...
5 years, 10 months ago (2015-02-12 20:37:07 UTC) #8
abarth-chromium
5 years, 10 months ago (2015-02-12 20:48:21 UTC) #9
Message was sent while issue was closed.
On 2015/02/12 at 20:37:07, zra wrote:
> We're starting to figure out how to get the Dart SDK including the standalone
Dart VM, pub, dartanalyze, etc. downloaded from google storage to third_party.
Once that's in place, a pub step to do the download could be part of the build.
Maybe try to coordinate with erg. I think he's doing preliminary work on this.

Neat.  Once that's working, we should switch over to using that for this code.

Powered by Google App Engine
This is Rietveld 408576698