Source/core/frame/Settings.in - Issue 921833003: Expose APIs for text track settings

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/frame/Settings.in

Issue 921833003: Expose APIs for text track settings (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed comments from fs Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/media/track/track-css-matching-user-override-settings.html ('K') | « LayoutTests/media/track/track-css-matching-user-override-settings-expected.txt ('k') | Source/core/html/track/vtt/VTTCue.h » ('j') | Source/core/testing/InternalSettings.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Defines properties which are available on the Settings object.	1 # Defines properties which are available on the Settings object.

2 #	2 #

3 # Please think carefully before adding a new Setting. Some questions to	3 # Please think carefully before adding a new Setting. Some questions to

4 # consider are:	4 # consider are:

5 # - Should this be a RuntimeEnabledFeature instead? Settings are for things	5 # - Should this be a RuntimeEnabledFeature instead? Settings are for things

6 # which we support either values of at runtime. Features are set at renderer	6 # which we support either values of at runtime. Features are set at renderer

7 # process startup and are never changed. Features also tend to be set to a	7 # process startup and are never changed. Features also tend to be set to a

8 # value based on the platform or the stability of the code in question, where	8 # value based on the platform or the stability of the code in question, where

9 # as settings both codepaths need to be stable.	9 # as settings both codepaths need to be stable.

10 # - How will you ensure test coverage of all relevant values of your setting?	10 # - How will you ensure test coverage of all relevant values of your setting?

(...skipping 298 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
309 inlineTextBoxAccessibilityEnabled initial=false	309 inlineTextBoxAccessibilityEnabled initial=false

310	310

311 # If true, context menu will be shown on mouse up instead of mouse down.	311 # If true, context menu will be shown on mouse up instead of mouse down.

312 # Typically enabled on Windows to match platform convention.	312 # Typically enabled on Windows to match platform convention.

313 showContextMenuOnMouseUp initial=false	313 showContextMenuOnMouseUp initial=false

314	314

315 disableReadingFromCanvas initial=false	315 disableReadingFromCanvas initial=false

316 strictMixedContentChecking initial=false	316 strictMixedContentChecking initial=false

317 strictPowerfulFeatureRestrictions initial=false	317 strictPowerfulFeatureRestrictions initial=false

318 logDnsPrefetchAndPreconnect initial=false	318 logDnsPrefetchAndPreconnect initial=false

	319

	320 # User style overrides for captions and subtitles

	321 textTrackBackgroundColor type=String

	322 textTrackFontFamily type=String

	323 textTrackFontStyle type=String

	324 textTrackFontVariant type=String

	325 textTrackTextColor type=String

	326 textTrackTextShadow type=String

	327 textTrackTextSize type=String

	328 textTrackWindowColor type=String

OLD	NEW