win8/delegate_execute/command_execute_impl.cc - Issue 92173002: Merge 237541 "Revert of https://codereview.chromium.org/71013004/"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: win8/delegate_execute/command_execute_impl.cc

Issue 92173002: Merge 237541 "Revert of https://codereview.chromium.org/71013004/" (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1721/src/

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: win8/delegate_execute/command_execute_impl.cc

===================================================================

--- win8/delegate_execute/command_execute_impl.cc (revision 237598)

+++ win8/delegate_execute/command_execute_impl.cc (working copy)

@@ -487,13 +487,12 @@

AtlTrace("Formatted command line is %ls\n", command_line.c_str());

- PROCESS_INFORMATION temp_process_info = {};

+ base::win::ScopedProcessInformation proc_info;

BOOL ret = CreateProcess(chrome_exe_.value().c_str(),

const_cast<LPWSTR>(command_line.c_str()),

NULL, NULL, FALSE, 0, NULL, NULL, &start_info_,

- &temp_process_info);

+ proc_info.Receive());

if (ret) {

- base::win::ScopedProcessInformation proc_info(temp_process_info);

AtlTrace("Process id is %d\n", proc_info.process_id());

AllowSetForegroundWindow(proc_info.process_id());

} else {

« no previous file with comments | « tools/gn/function_exec_script.cc ('k') | win8/test/metro_registration_helper.cc » ('j') | no next file with comments »