sandbox/win/src/job_unittest.cc - Issue 92173002: Merge 237541 "Revert of https://codereview.chromium.org/71013004/"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/win/src/job_unittest.cc

Issue 92173002: Merge 237541 "Revert of https://codereview.chromium.org/71013004/" (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1721/src/

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sandbox/win/src/job_unittest.cc

===================================================================

--- sandbox/win/src/job_unittest.cc (revision 237598)

+++ sandbox/win/src/job_unittest.cc (working copy)

@@ -164,11 +164,10 @@

wchar_t notepad[] = L"notepad";

STARTUPINFO si = { sizeof(si) };

- PROCESS_INFORMATION temp_process_info = {};

+ base::win::ScopedProcessInformation pi;

result = ::CreateProcess(NULL, notepad, NULL, NULL, FALSE, 0, NULL, NULL, &si,

- &temp_process_info);

+ pi.Receive());

ASSERT_TRUE(result);

- base::win::ScopedProcessInformation pi(temp_process_info);

ASSERT_EQ(ERROR_SUCCESS, job.AssignProcessToJob(pi.process_handle()));

// Get the job handle.

« no previous file with comments | « sandbox/win/src/Wow64.cc ('k') | sandbox/win/src/policy_target_test.cc » ('j') | no next file with comments »