Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5089)

Unified Diff: chrome/installer/util/google_update_util.cc

Issue 92173002: Merge 237541 "Revert of https://codereview.chromium.org/71013004/" (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1721/src/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/test/alternate_version_generator.cc ('k') | chrome/test/ui/ui_test_suite.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/google_update_util.cc
===================================================================
--- chrome/installer/util/google_update_util.cc (revision 237598)
+++ chrome/installer/util/google_update_util.cc (working copy)
@@ -95,9 +95,9 @@
bool success = false;
base::win::ScopedHandle process;
int exit_code = 0;
- VLOG(0) << "Launching: " << cmd_string;
+ LOG(INFO) << "Launching: " << cmd_string;
if (!base::LaunchProcess(cmd_string, base::LaunchOptions(),
- &process)) {
+ process.Receive())) {
PLOG(ERROR) << "Failed to launch (" << cmd_string << ")";
} else if (!base::WaitForExitCodeWithTimeout(process, &exit_code, timeout)) {
// The GetExitCodeProcess failed or timed-out.
@@ -174,7 +174,7 @@
} // namespace
bool EnsureUserLevelGoogleUpdatePresent() {
- VLOG(0) << "Ensuring Google Update is present at user-level.";
+ LOG(INFO) << "Ensuring Google Update is present at user-level.";
bool success = false;
if (IsGoogleUpdatePresent(false)) {
« no previous file with comments | « chrome/installer/test/alternate_version_generator.cc ('k') | chrome/test/ui/ui_test_suite.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698