base/win/startup_information_unittest.cc - Issue 92173002: Merge 237541 "Revert of https://codereview.chromium.org/71013004/"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/win/startup_information_unittest.cc

Issue 92173002: Merge 237541 "Revert of https://codereview.chromium.org/71013004/" (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1721/src/

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/win/scoped_process_information_unittest.cc ('k') | chrome/browser/extensions/api/messaging/native_process_launcher_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/win/startup_information_unittest.cc

===================================================================

--- base/win/startup_information_unittest.cc (revision 237598)

+++ base/win/startup_information_unittest.cc (working copy)

@@ -38,6 +38,7 @@

if (base::win::GetVersion() < base::win::VERSION_VISTA)

return;

+ base::win::ScopedProcessInformation process_info;

base::win::StartupInformation startup_info;

HANDLE section = ::CreateFileMappingW(INVALID_HANDLE_VALUE, NULL,

@@ -64,13 +65,10 @@

std::wstring cmd_line =

this->MakeCmdLine("FireInheritedEvents", false).GetCommandLineString();

- PROCESS_INFORMATION temp_process_info = {};

ASSERT_TRUE(::CreateProcess(NULL, const_cast<wchar_t*>(cmd_line.c_str()),

NULL, NULL, true, EXTENDED_STARTUPINFO_PRESENT,

NULL, NULL, startup_info.startup_info(),

- &temp_process_info)) << ::GetLastError();

- base::win::ScopedProcessInformation process_info(temp_process_info);

+ process_info.Receive())) << ::GetLastError();

// Only the first event should be signalled

EXPECT_EQ(WAIT_OBJECT_0, ::WaitForMultipleObjects(2, events, false,

4000));