Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 921683006: [tests]: fix exponentiation in harmony array-concat tests (Closed)

Created:
5 years, 10 months ago by caitp (gmail)
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tests]: fix exponentiation in harmony array-concat tests BUG= LOG=N R=adamk@chromium.org Committed: https://crrev.com/ea3f39486c37d6188706ac22081c610c9acc29db Cr-Commit-Position: refs/heads/master@{#26710}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M test/mjsunit/harmony/array-concat.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
caitp (gmail)
PTAL A while ago when I wrote this, I forgot(!) that there is no exponentiation ...
5 years, 10 months ago (2015-02-16 22:35:37 UTC) #1
caitp (gmail)
On 2015/02/16 22:35:37, caitp wrote: > PTAL > > A while ago when I wrote ...
5 years, 10 months ago (2015-02-16 22:44:09 UTC) #3
adamk
lgtm Amusing that slipped through initial code review, I guess it's easy for eyes to ...
5 years, 10 months ago (2015-02-17 19:23:54 UTC) #5
caitp (gmail)
On 2015/02/17 19:23:54, adamk wrote: > lgtm > > Amusing that slipped through initial code ...
5 years, 10 months ago (2015-02-17 22:04:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/921683006/1
5 years, 10 months ago (2015-02-17 22:05:45 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 22:28:04 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 22:28:23 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea3f39486c37d6188706ac22081c610c9acc29db
Cr-Commit-Position: refs/heads/master@{#26710}

Powered by Google App Engine
This is Rietveld 408576698