Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 921683005: Remove 'using' declarations in relocation packer's debug.h. (Closed)

Created:
5 years, 10 months ago by simonb (inactive)
Modified:
5 years, 10 months ago
Reviewers:
rmcilroy
CC:
chromium-reviews, Feng Qian
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove 'using' declarations in relocation packer's debug.h. Back out 'using' declarations added in 7d58839. These break builds where host_clang=0: BUG=385553 Committed: https://crrev.com/2510b4b9d48eade75d5c39a39dfa31b9c4b5456c Cr-Commit-Position: refs/heads/master@{#316566}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M tools/relocation_packer/src/debug.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
simonb (inactive)
5 years, 10 months ago (2015-02-16 18:49:42 UTC) #2
rmcilroy
On 2015/02/16 18:49:42, simonb wrote: lgtm.
5 years, 10 months ago (2015-02-17 09:39:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/921683005/1
5 years, 10 months ago (2015-02-17 10:57:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/43148)
5 years, 10 months ago (2015-02-17 11:02:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/921683005/1
5 years, 10 months ago (2015-02-17 12:37:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 12:40:09 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 12:40:52 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2510b4b9d48eade75d5c39a39dfa31b9c4b5456c
Cr-Commit-Position: refs/heads/master@{#316566}

Powered by Google App Engine
This is Rietveld 408576698