Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 921683004: Revert: Issue 545053002: Add still image capture interface for VideoCaptureDevice. (Closed)

Created:
5 years, 10 months ago by mcasas
Modified:
5 years, 10 months ago
Reviewers:
Owen Lin, Pawel Osciak
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert: Issue 545053002: Add still image capture interface for VideoCaptureDevice. These parts are not used ATM, this CL removes them until further notice. > Add still image capture interface for VideoCaptureDevice. > > BUG=413086 > TEST=Run the media_unittests on peach_pit. > > Committed: https://crrev.com/fd5bdd2688768683e30b27941f181597a849656d > Cr-Commit-Position: refs/heads/master@{#298009} TBR=posciak@chromium.org, perkj@chromium.org, tommi@chromium.org BUG=413086, 440843 Committed: https://crrev.com/79f434392d01f8ef3d3457fba42e78120278bf9f Cr-Commit-Position: refs/heads/master@{#318183}

Patch Set 1 #

Patch Set 2 : Rebased (media/video/capture/video_capture_types.* went to media/base) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -100 lines) Patch
M media/base/video_capture_types.h View 1 1 chunk +0 lines, -17 lines 0 comments Download
M media/base/video_capture_types.cc View 1 1 chunk +0 lines, -9 lines 0 comments Download
M media/video/capture/video_capture_device.h View 1 2 chunks +0 lines, -61 lines 0 comments Download
M media/video/capture/video_capture_device.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M media/video/capture/video_capture_device_factory.h View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
mcasas
owenlin@ PTAL.
5 years, 10 months ago (2015-02-16 16:45:15 UTC) #2
Pawel Osciak
On 2015/02/16 16:45:15, mcasas wrote: > owenlin@ PTAL. Could you please create this by saying ...
5 years, 10 months ago (2015-02-16 23:52:53 UTC) #3
mcasas
Guys PTAL.
5 years, 10 months ago (2015-02-17 15:31:50 UTC) #5
Owen Lin
On 2015/02/17 15:31:50, mcasas wrote: > Guys PTAL. Lgtm
5 years, 10 months ago (2015-02-25 16:24:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/921683004/1
5 years, 10 months ago (2015-02-26 01:38:11 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 10 months ago (2015-02-26 01:38:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/921683004/1
5 years, 10 months ago (2015-02-26 01:40:14 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/59) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 10 months ago (2015-02-26 01:43:29 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/921683004/20001
5 years, 10 months ago (2015-02-26 02:35:29 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-26 04:12:40 UTC) #18
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 04:13:12 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/79f434392d01f8ef3d3457fba42e78120278bf9f
Cr-Commit-Position: refs/heads/master@{#318183}

Powered by Google App Engine
This is Rietveld 408576698