Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 921673003: [Fetch] Split layout tests (Closed)

Created:
5 years, 10 months ago by hiroshige
Modified:
5 years, 10 months ago
Reviewers:
yhirano
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[Fetch] Split layout tests Move tests that call fetch() with mode='no-cors' to separate files. - block-mixed-content-nocors.js - fetch-access-control-nocors.js (from fetch-access-control.js and fetch-access-control-cors.js) - fetch-access-control-auth-nocors.js - fetch-access-control-cookie-nocors.js - fetch-access-control-redirect-nocors.js Tests with 'mode=no-cors' in URLs are moved. Tests without mode parameter in URLs are also moved and marked by onlyOnServiceWorkerProxiedTest(), because these tests are testing that default mode in serviceworker-proxied tests is no-cors. Tests that create Request with mode='no-cors' but do not call fetch() with such requests are not moved. Split other fetch-access-control* tests: - fetch-access-control-cors-preflight.js (from fetch-access-control-cors.js) - fetch-access-control-redirect-credentials.js - fetch-access-control-redirect-loop.js (from fetch-access-control-redirect.js) BUG=457157 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190048

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+697 lines, -996 lines) Patch
M LayoutTests/http/tests/fetch/resources/fetch-test-helpers.js View 1 chunk +65 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/fetch/script-tests/block-mixed-content.js View 1 chunk +2 lines, -64 lines 0 comments Download
A LayoutTests/http/tests/fetch/script-tests/block-mixed-content-nocors.js View 1 chunk +22 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/fetch/script-tests/fetch-access-control.js View 3 chunks +3 lines, -35 lines 0 comments Download
M LayoutTests/http/tests/fetch/script-tests/fetch-access-control-auth.js View 2 chunks +0 lines, -39 lines 0 comments Download
A LayoutTests/http/tests/fetch/script-tests/fetch-access-control-auth-nocors.js View 1 chunk +63 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/fetch/script-tests/fetch-access-control-cookie.js View 2 chunks +12 lines, -31 lines 0 comments Download
A LayoutTests/http/tests/fetch/script-tests/fetch-access-control-cookie-nocors.js View 1 chunk +84 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/fetch/script-tests/fetch-access-control-cors.js View 3 chunks +2 lines, -406 lines 0 comments Download
A + LayoutTests/http/tests/fetch/script-tests/fetch-access-control-cors-preflight.js View 2 chunks +3 lines, -102 lines 0 comments Download
A LayoutTests/http/tests/fetch/script-tests/fetch-access-control-nocors.js View 1 chunk +79 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/fetch/script-tests/fetch-access-control-redirect.js View 7 chunks +0 lines, -210 lines 0 comments Download
A LayoutTests/http/tests/fetch/script-tests/fetch-access-control-redirect-credentials.js View 1 chunk +105 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/fetch/script-tests/fetch-access-control-redirect-loop.js View 1 chunk +50 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/fetch/script-tests/fetch-access-control-redirect-nocors.js View 1 chunk +95 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker-proxied/fetch-access-control-auth-nocors.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker-proxied/fetch-access-control-auth-nocors-base-https-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker-proxied/fetch-access-control-auth-nocors-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker-proxied/fetch-access-control-cookie-nocors.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker-proxied/fetch-access-control-cookie-nocors-base-https-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker-proxied/fetch-access-control-cookie-nocors-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker-proxied/fetch-access-control-cors-preflight.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker-proxied/fetch-access-control-cors-preflight-base-https-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker-proxied/fetch-access-control-cors-preflight-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker-proxied/fetch-access-control-nocors.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker-proxied/fetch-access-control-nocors-base-https-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker-proxied/fetch-access-control-nocors-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker-proxied/fetch-access-control-redirect-credentials.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker-proxied/fetch-access-control-redirect-credentials-base-https-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker-proxied/fetch-access-control-redirect-credentials-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker-proxied/fetch-access-control-redirect-loop.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker-proxied/fetch-access-control-redirect-loop-base-https-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker-proxied/fetch-access-control-redirect-loop-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker-proxied/fetch-access-control-redirect-nocors.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker-proxied/fetch-access-control-redirect-nocors-base-https-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker-proxied/fetch-access-control-redirect-nocors-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker/block-mixed-content-nocors-base-https.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker/fetch-access-control-auth-nocors.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker/fetch-access-control-auth-nocors-base-https-other-https.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker/fetch-access-control-auth-nocors-other-https.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker/fetch-access-control-cookie-nocors.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker/fetch-access-control-cookie-nocors-base-https-other-https.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker/fetch-access-control-cookie-nocors-other-https.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker/fetch-access-control-cors-preflight.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker/fetch-access-control-cors-preflight-base-https-other-https.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker/fetch-access-control-cors-preflight-other-https.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker/fetch-access-control-nocors.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker/fetch-access-control-nocors-base-https-other-https.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker/fetch-access-control-nocors-other-https.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker/fetch-access-control-redirect-credentials.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker/fetch-access-control-redirect-credentials-base-https-other-https.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker/fetch-access-control-redirect-credentials-other-https.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker/fetch-access-control-redirect-loop.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker/fetch-access-control-redirect-loop-base-https-other-https.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker/fetch-access-control-redirect-loop-other-https.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker/fetch-access-control-redirect-nocors.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker/fetch-access-control-redirect-nocors-base-https-other-https.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker/fetch-access-control-redirect-nocors-other-https.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/http/tests/fetch/window/block-mixed-content-nocors-base-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/window/fetch-access-control-auth-nocors.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/window/fetch-access-control-auth-nocors-base-https-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/window/fetch-access-control-auth-nocors-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/window/fetch-access-control-cookie-nocors.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/window/fetch-access-control-cookie-nocors-base-https-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/window/fetch-access-control-cookie-nocors-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/window/fetch-access-control-cors-preflight.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/window/fetch-access-control-cors-preflight-base-https-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/window/fetch-access-control-cors-preflight-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/window/fetch-access-control-nocors.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/window/fetch-access-control-nocors-base-https-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/window/fetch-access-control-nocors-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/window/fetch-access-control-redirect-credentials.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/window/fetch-access-control-redirect-credentials-base-https-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/window/fetch-access-control-redirect-credentials-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/window/fetch-access-control-redirect-loop.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/window/fetch-access-control-redirect-loop-base-https-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/window/fetch-access-control-redirect-loop-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/window/fetch-access-control-redirect-nocors.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/window/fetch-access-control-redirect-nocors-base-https-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/window/fetch-access-control-redirect-nocors-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/workers/block-mixed-content-nocors-base-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/workers/fetch-access-control-auth-nocors.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/workers/fetch-access-control-auth-nocors-base-https-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/workers/fetch-access-control-auth-nocors-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/workers/fetch-access-control-cookie-nocors.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/workers/fetch-access-control-cookie-nocors-base-https-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/workers/fetch-access-control-cookie-nocors-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/workers/fetch-access-control-cors-preflight.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/workers/fetch-access-control-cors-preflight-base-https-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/workers/fetch-access-control-cors-preflight-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/workers/fetch-access-control-nocors.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/workers/fetch-access-control-nocors-base-https-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/workers/fetch-access-control-nocors-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/workers/fetch-access-control-redirect-credentials.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/workers/fetch-access-control-redirect-credentials-base-https-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/workers/fetch-access-control-redirect-credentials-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/workers/fetch-access-control-redirect-loop.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/workers/fetch-access-control-redirect-loop-base-https-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/workers/fetch-access-control-redirect-loop-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/workers/fetch-access-control-redirect-nocors.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/workers/fetch-access-control-redirect-nocors-base-https-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/workers/fetch-access-control-redirect-nocors-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/resources/fetch-access-control-util.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
hiroshige
I split this CL from https://codereview.chromium.org/891753002/ to confirm the tests succeeds with no-cors enabled.
5 years, 10 months ago (2015-02-12 10:05:40 UTC) #2
yhirano
lgtm
5 years, 10 months ago (2015-02-12 12:09:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/921673003/1
5 years, 10 months ago (2015-02-12 12:32:46 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 12:45:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190048

Powered by Google App Engine
This is Rietveld 408576698