Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 921633006: Drop weak_ptr_factory in SkyDebugger. (Closed)

Created:
5 years, 10 months ago by ppi
Modified:
5 years, 10 months ago
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Drop weak_ptr_factory in SkyDebugger. It seems not to be used for anything. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/bd7075f96e438641b7f18dec1e645de37f96301f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M sky/tools/debugger/debugger.cc View 3 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ppi
Hi Eric, ptal.
5 years, 10 months ago (2015-02-13 16:25:01 UTC) #2
abarth-chromium
lgtm
5 years, 10 months ago (2015-02-13 16:35:22 UTC) #4
ppi
5 years, 10 months ago (2015-02-13 17:24:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bd7075f96e438641b7f18dec1e645de37f96301f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698