Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 921633004: clang/win: For 64-bit builds, enable warnings-as-errors and stop falling back to CL. (Closed)

Created:
5 years, 10 months ago by Nico
Modified:
5 years, 10 months ago
Reviewers:
hans
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: For 64-bit builds, enable warnings-as-errors and stop falling back to CL. Clang can now build all of chrome's translation units in 64-bit. Remove /fallback so that the bot will turn red if this regresses. Also turn on warnings-as-errors, so that warnings also turn the build red (instead of just causing a fallback as before). Also remove a superfluous 'RuntimeTypeInfo': 'false': This is already the default for non-clang builds too. (And for the few places where we do need RTTI -- icu -- clang has been able to emit it for months now.) BUG=82385 R=hans@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/5e66594551c7bbeda37cb640314d24429387ae3b

Patch Set 1 #

Patch Set 2 : err #

Patch Set 3 : err2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M build/common.gypi View 1 2 2 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Nico
!!!
5 years, 10 months ago (2015-02-13 01:50:29 UTC) #2
hans
lgtm!!!
5 years, 10 months ago (2015-02-13 02:00:59 UTC) #3
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/5e66594551c7bbeda37cb640314d24429387ae3b Cr-Commit-Position: refs/heads/master@{#316141}
5 years, 10 months ago (2015-02-13 03:00:51 UTC) #4
Nico
5 years, 10 months ago (2015-02-13 03:00:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
5e66594551c7bbeda37cb640314d24429387ae3b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698