Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 921583005: Revert of HID-detection screen moved to screenContext. (Closed)

Created:
5 years, 10 months ago by jonross
Modified:
5 years, 10 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, dzhioev+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of HID-detection screen moved to screenContext. (patchset #8 id:140001 of https://codereview.chromium.org/898453002/) Reason for revert: This change has introduced an error on two Chrome OS tests: LoginUITest.OobeCatchException LoginUITest.OobeNoExceptions Full logs: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/37465 Original issue's description: > HID-detection screen moved to screenContext. > > BUG=433797, 456779 > > Committed: https://crrev.com/cc4feaa0828ee6d58c6a3eecf67e9d6bf72588a7 > Cr-Commit-Position: refs/heads/master@{#315788} > > Committed: https://crrev.com/7a5f7055c7a3e4b0e6a678187bb92541c116ab76 > Cr-Commit-Position: refs/heads/master@{#315981} TBR=antrim@chromium.org,merkulova@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=433797, 456779 Committed: https://crrev.com/10319b6135443d83af8c277dca6b7cd9d04f031b Cr-Commit-Position: refs/heads/master@{#316015}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+806 lines, -990 lines) Patch
D chrome/browser/chromeos/login/screens/hid_detection_model.h View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/browser/chromeos/login/screens/hid_detection_model.cc View 1 chunk +0 lines, -38 lines 0 comments Download
M chrome/browser/chromeos/login/screens/hid_detection_screen.h View 1 chunk +10 lines, -183 lines 0 comments Download
M chrome/browser/chromeos/login/screens/hid_detection_screen.cc View 1 chunk +17 lines, -515 lines 0 comments Download
A chrome/browser/chromeos/login/screens/hid_detection_screen_actor.h View 1 chunk +46 lines, -0 lines 0 comments Download
D chrome/browser/chromeos/login/screens/hid_detection_view.h View 1 chunk +0 lines, -36 lines 0 comments Download
M chrome/browser/chromeos/login/ui/oobe_display.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 5 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 4 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.js View 6 chunks +47 lines, -103 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/hid_detection_screen_handler.h View 2 chunks +168 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/hid_detection_screen_handler.cc View 6 chunks +498 lines, -27 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jonross
Created Revert of HID-detection screen moved to screenContext.
5 years, 10 months ago (2015-02-12 19:12:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/921583005/1
5 years, 10 months ago (2015-02-12 19:14:00 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-12 19:15:14 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 19:15:47 UTC) #4
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/10319b6135443d83af8c277dca6b7cd9d04f031b
Cr-Commit-Position: refs/heads/master@{#316015}

Powered by Google App Engine
This is Rietveld 408576698