Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 921563002: Linux Sandbox: reorganize (Closed)

Created:
5 years, 10 months ago by jln (very slow on Chromium)
Modified:
5 years, 10 months ago
Reviewers:
mdempsky
CC:
chromium-reviews, darin-cc_chromium.org, jam, rickyz+watch_chromium.org, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Linux Sandbox: reorganize This CL creates a new integrations_tests/ directory, and splits bpf_dsl_more_unittests.cc into two files. Moreover, this creates a new system_headers/ directory and moves current system headers there. This helps organizing our dependencies better. BUG=449357 TBR=mseaborn Committed: https://crrev.com/aedcc3ee8d28d0354ad3106ef8deaa369506ab3c Cr-Commit-Position: refs/heads/master@{#315922}

Patch Set 1 #

Patch Set 2 : Fix .gn file. #

Patch Set 3 : Fix android_futex includes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+318 lines, -11224 lines) Patch
M components/nacl/loader/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/nacl/loader/nonsfi/nonsfi_sandbox.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/loader/nonsfi/nonsfi_sandbox_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/loader/sandbox_linux/nacl_bpf_sandbox_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/sandbox_linux/bpf_cros_arm_gpu_policy_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/sandbox_linux/bpf_gpu_policy_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/sandbox_linux/bpf_ppapi_policy_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/sandbox_linux/bpf_renderer_policy_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/sandbox_linux/bpf_utility_policy_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/sandbox_linux/sandbox_seccomp_bpf_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/BUILD.gn View 1 3 chunks +13 lines, -12 lines 0 comments Download
M sandbox/linux/bpf_dsl/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
D sandbox/linux/bpf_dsl/bpf_dsl_more_unittest.cc View 1 chunk +0 lines, -2399 lines 0 comments Download
A + sandbox/linux/integration_tests/DEPS View 1 chunk +3 lines, -2 lines 0 comments Download
A + sandbox/linux/integration_tests/bpf_dsl_seccomp_unittest.cc View 4 chunks +3 lines, -149 lines 0 comments Download
A + sandbox/linux/integration_tests/namespace_unix_domain_socket_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A sandbox/linux/integration_tests/seccomp_broker_process_unittest.cc View 1 chunk +180 lines, -0 lines 0 comments Download
M sandbox/linux/sandbox_linux.gypi View 1 chunk +12 lines, -12 lines 0 comments Download
M sandbox/linux/sandbox_linux_test_sources.gypi View 2 chunks +3 lines, -2 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/DEPS View 1 chunk +2 lines, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/baseline_policy.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/baseline_policy_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/syscall_sets.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/linux/seccomp-bpf/bpf_tests_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf/sandbox_bpf.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf/sandbox_bpf_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf/syscall.h View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf/trap.cc View 1 chunk +1 line, -1 line 0 comments Download
A sandbox/linux/services/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
D sandbox/linux/services/android_arm64_ucontext.h View 1 chunk +0 lines, -29 lines 0 comments Download
D sandbox/linux/services/android_arm_ucontext.h View 1 chunk +0 lines, -32 lines 0 comments Download
D sandbox/linux/services/android_futex.h View 1 chunk +0 lines, -80 lines 0 comments Download
D sandbox/linux/services/android_i386_ucontext.h View 1 chunk +0 lines, -79 lines 0 comments Download
D sandbox/linux/services/android_mips_ucontext.h View 1 chunk +0 lines, -51 lines 0 comments Download
D sandbox/linux/services/android_ucontext.h View 1 chunk +0 lines, -28 lines 0 comments Download
D sandbox/linux/services/android_x86_64_ucontext.h View 1 chunk +0 lines, -88 lines 0 comments Download
D sandbox/linux/services/arm64_linux_syscalls.h View 1 chunk +0 lines, -1062 lines 0 comments Download
D sandbox/linux/services/arm_linux_syscalls.h View 1 chunk +0 lines, -1409 lines 0 comments Download
D sandbox/linux/services/linux_syscalls.h View 1 chunk +0 lines, -37 lines 0 comments Download
D sandbox/linux/services/mips64_linux_syscalls.h View 1 chunk +0 lines, -1266 lines 0 comments Download
D sandbox/linux/services/mips_linux_syscalls.h View 1 chunk +0 lines, -1428 lines 0 comments Download
M sandbox/linux/services/syscall_wrappers.cc View 1 chunk +1 line, -1 line 0 comments Download
D sandbox/linux/services/unix_domain_socket_unittest.cc View 1 chunk +0 lines, -267 lines 0 comments Download
D sandbox/linux/services/x86_32_linux_syscalls.h View 1 chunk +0 lines, -1426 lines 0 comments Download
D sandbox/linux/services/x86_64_linux_syscalls.h View 1 chunk +0 lines, -1294 lines 0 comments Download
M sandbox/linux/syscall_broker/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/syscall_broker/broker_host.cc View 1 chunk +1 line, -1 line 0 comments Download
A + sandbox/linux/system_headers/android_arm64_ucontext.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + sandbox/linux/system_headers/android_arm_ucontext.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + sandbox/linux/system_headers/android_futex.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + sandbox/linux/system_headers/android_i386_ucontext.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + sandbox/linux/system_headers/android_mips_ucontext.h View 2 chunks +3 lines, -3 lines 0 comments Download
A sandbox/linux/system_headers/android_ucontext.h View 1 chunk +28 lines, -0 lines 0 comments Download
A + sandbox/linux/system_headers/android_x86_64_ucontext.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + sandbox/linux/system_headers/arm64_linux_syscalls.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + sandbox/linux/system_headers/arm_linux_syscalls.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + sandbox/linux/system_headers/linux_syscalls.h View 1 chunk +9 lines, -9 lines 0 comments Download
A + sandbox/linux/system_headers/mips64_linux_syscalls.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + sandbox/linux/system_headers/mips_linux_syscalls.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + sandbox/linux/system_headers/x86_32_linux_syscalls.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + sandbox/linux/system_headers/x86_64_linux_syscalls.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
jln (very slow on Chromium)
Matthew: could you please take a look? This is pretty much entirely mechanical. If you ...
5 years, 10 months ago (2015-02-12 01:01:51 UTC) #2
mdempsky
LGTM I suspect we can move seccomp-bpf/linux_seccomp.h into system_headers too (in a separate CL).
5 years, 10 months ago (2015-02-12 02:46:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/921563002/40001
5 years, 10 months ago (2015-02-12 03:01:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/42193)
5 years, 10 months ago (2015-02-12 03:07:17 UTC) #7
jln (very slow on Chromium)
mseaborn: TBR for components/nacl/loader/DEPS
5 years, 10 months ago (2015-02-12 03:13:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/921563002/40001
5 years, 10 months ago (2015-02-12 03:14:28 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-12 03:18:18 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 03:20:14 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/aedcc3ee8d28d0354ad3106ef8deaa369506ab3c
Cr-Commit-Position: refs/heads/master@{#315922}

Powered by Google App Engine
This is Rietveld 408576698